Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: deprecate envoy.reloadable_features.http1_connection_close_header_in_redirect #35603

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

danzh2010
Copy link
Contributor

Commit Message: remove above runtime guard and update changelog

Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Fixes #33621

Signed-off-by: Dan Zhang <[email protected]>
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #35603 was opened by danzh2010.

see: more, trace.

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danzh2010
Copy link
Contributor Author

/retest

@alyssawilk
Copy link
Contributor

coverage had a permafail so this may need a main merge

@adisuissa adisuissa merged commit 121a541 into envoyproxy:main Aug 8, 2024
51 checks passed
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
…der_in_redirect` (envoyproxy#35603)

Signed-off-by: Dan Zhang <[email protected]>
Co-authored-by: Dan Zhang <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
…der_in_redirect` (envoyproxy#35603)

Signed-off-by: Dan Zhang <[email protected]>
Co-authored-by: Dan Zhang <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_http1_connection_close_header_in_redirect deprecation
4 participants