Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix diskspace issue when caching checks #35599

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 6, 2024

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft August 6, 2024 13:33
@phlax phlax force-pushed the check-diskspace branch from 4a0747f to 9f4a849 Compare August 6, 2024 14:32
@phlax phlax changed the title [WIP/TESTING] ci: Fix diskspace issue when caching checks ci: Fix diskspace issue when caching checks Aug 6, 2024
@phlax phlax marked this pull request as ready for review August 6, 2024 14:32
@phlax phlax force-pushed the check-diskspace branch from 9f4a849 to 4302b84 Compare August 6, 2024 14:36
alyssawilk
alyssawilk previously approved these changes Aug 6, 2024
@phlax phlax enabled auto-merge (squash) August 6, 2024 15:24
ravenblackx
ravenblackx previously approved these changes Aug 6, 2024
@phlax
Copy link
Member Author

phlax commented Aug 6, 2024

not sure why but this now fails with a different error - i thought it worked the first time i ran it - ill debug further

@phlax phlax dismissed stale reviews from ravenblackx and alyssawilk via da547e8 August 6, 2024 17:46
@phlax phlax force-pushed the check-diskspace branch from da547e8 to e6806aa Compare August 6, 2024 19:01
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the check-diskspace branch from e6806aa to a756e31 Compare August 6, 2024 19:08
@@ -83,6 +83,7 @@ jobs:
cacheName: $(CI_TARGET)
envoyBuildFilterExample: $(ENVOY_FILTER_EXAMPLE)
cacheTestResults: ${{ parameters.cacheTestResults }}
diskspaceHack: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooc what does this do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes all the default installed and unused dev environments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its the nuclear solution - but it will work for now - ill try and make it only happen on coverage in a follow up - but lets get things working (this does)

@phlax
Copy link
Member Author

phlax commented Aug 6, 2024

ill push this through to unbreak presubmit/main

@phlax phlax disabled auto-merge August 6, 2024 19:54
@phlax phlax merged commit 12f83d0 into envoyproxy:main Aug 6, 2024
50 checks passed
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
using the CI diskspace hack

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Aug 9, 2024
using the CI diskspace hack

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Aug 12, 2024
using the CI diskspace hack

Signed-off-by: Ryan Northey <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
using the CI diskspace hack

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants