Make incompatible command-line args an error #35570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <[email protected]>
Signed-off-by: Raven Black <[email protected]>
botengyao
reviewed
Aug 2, 2024
source/server/options_impl.cc
Outdated
| enable_fine_grain_logging_ = enable_fine_grain_logging.getValue(); | ||
| if (enable_fine_grain_logging_ && !component_log_level.getValue().empty()) { | ||
| throw MalformedArgvException( | ||
| std::string{"error: --component-log-level will not work with --enable-fine-grain-logging"}); |
There was a problem hiding this comment.
nit: std::string can be removed?
Signed-off-by: Raven Black <[email protected]>
Signed-off-by: Raven Black <[email protected]>
botengyao
approved these changes
Aug 2, 2024
|
/assgin-from @envoyproxy/senior-maintainers |
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
mattklein123
approved these changes
Aug 5, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Commit Message: Make incompatible command-line args an error Additional Description: Per envoyproxy#35073, `--enable-fine-grain-logging` and `--component-log-level` don't make sense at the same time, one of them will be overridden by the other in a way that can be surprising for the user. This PR makes it an error to apply both, so the user is not surprised by not getting the logs they expected at runtime. Risk Level: Small. May make existing command-lines with ineffective options fail. Testing: Added coverage. Docs Changes: Updated command-line options docs. Release Notes: Yes, under minor behavior changes. Platform Specific Features: n/a --------- Signed-off-by: Raven Black <[email protected]> Signed-off-by: Martin Duke <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: Make incompatible command-line args an error Additional Description: Per envoyproxy#35073, `--enable-fine-grain-logging` and `--component-log-level` don't make sense at the same time, one of them will be overridden by the other in a way that can be surprising for the user. This PR makes it an error to apply both, so the user is not surprised by not getting the logs they expected at runtime. Risk Level: Small. May make existing command-lines with ineffective options fail. Testing: Added coverage. Docs Changes: Updated command-line options docs. Release Notes: Yes, under minor behavior changes. Platform Specific Features: n/a --------- Signed-off-by: Raven Black <[email protected]> Signed-off-by: asingh-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Make incompatible command-line args an error
Additional Description: Per #35073,
--enable-fine-grain-loggingand--component-log-leveldon't make sense at the same time, one of them will be overridden by the other in a way that can be surprising for the user. This PR makes it an error to apply both, so the user is not surprised by not getting the logs they expected at runtime.Risk Level: Small. May make existing command-lines with ineffective options fail.
Testing: Added coverage.
Docs Changes: Updated command-line options docs.
Release Notes: Yes, under minor behavior changes.
Platform Specific Features: n/a