quic: fix stream reset error stats #35548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Zhang <[email protected]>
Signed-off-by: Dan Zhang <[email protected]>
|
/assign @RyanTheOptimist |
|
/retest |
RyanTheOptimist
previously approved these changes
Aug 5, 2024
|
/retest |
|
Looks like this needs a main merge and possibly a re-test. |
Signed-off-by: Dan Zhang <[email protected]>
|
/wait |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Dan Zhang <[email protected]>
|
/retest |
|
/wait |
Signed-off-by: Dan Zhang <[email protected]>
|
/retest |
|
@RyanTheOptimist finally passed! Can this get merged before merging conflict coming up? |
RyanTheOptimist
approved these changes
Aug 8, 2024
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: fix a stats error where outgoing QUIC reset error stats is mistakenly incremented both when sending RESET_STREAM frame and receiving RESET_STREAM frame in MaybeSendRstStreamFrame(). As a result, `.tx.quic_reset_stream_error_code_XXX` is counting `.rx.quic_reset_stream_error_code_XXX` into it. Additional Description: This PR also refactor the stats increment into QuicFilterManagerConnectionImpl shared between client and server sessions. Risk Level: low, stats only Testing: new unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Dan Zhang <[email protected]> Co-authored-by: Dan Zhang <[email protected]> Signed-off-by: asingh-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: fix a stats error where outgoing QUIC reset error stats is mistakenly incremented both when sending RESET_STREAM frame and receiving RESET_STREAM frame in MaybeSendRstStreamFrame(). As a result,
.tx.quic_reset_stream_error_code_XXXis counting.rx.quic_reset_stream_error_code_XXXinto it.Additional Description: This PR also refactor the stats increment into QuicFilterManagerConnectionImpl shared between client and server sessions.
Risk Level: low, stats only
Testing: new unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A