implement per-route override for rbac stat prefixes #35531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antoniovleonti <[email protected]>
yanavlasov
previously approved these changes
Aug 1, 2024
|
Will wait for @yangminzhu review before merging. |
|
/wait-any |
|
@yangminzhu gentle ping |
yangminzhu
reviewed
Aug 6, 2024
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
|
/retest |
Signed-off-by: antoniovleonti <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
@antoniovleonti it looks like main merge is needed to address coverage failure. |
yanavlasov
approved these changes
Aug 7, 2024
Signed-off-by: antoniovleonti <[email protected]>
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Currently, if you only have stat prefixes configured in per-route config and not the base config, the stat prefix will be empty. this PR addresses that. --------- Signed-off-by: antoniovleonti <[email protected]> Signed-off-by: Martin Duke <[email protected]>
RyanTheOptimist
added a commit
that referenced
this pull request
Aug 9, 2024
This reverts commit 751217c.
RyanTheOptimist
added a commit
to RyanTheOptimist/envoy
that referenced
this pull request
Aug 9, 2024
…xy#35531)" This reverts commit 751217c. Signed-off-by: Ryan Hamilton <[email protected]>
RyanTheOptimist
added a commit
to RyanTheOptimist/envoy
that referenced
this pull request
Aug 9, 2024
…xy#35531)" This reverts commit 751217c. Signed-off-by: Ryan Hamilton <[email protected]>
RyanTheOptimist
added a commit
that referenced
this pull request
Aug 9, 2024
…#35655) Revert "implement per-route override for rbac stat prefixes (#35531)" Causing //test/extensions/filters/network/rbac:integration_test to flakily time out. This reverts commit 751217c. Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: Ryan Hamilton <[email protected]>
antoniovleonti
added a commit
to antoniovleonti/envoy
that referenced
this pull request
Aug 13, 2024
…oxy#35531)" (envoyproxy#35655) This reverts commit 7ae5ca5. Signed-off-by: antoniovleonti <[email protected]>
yanavlasov
pushed a commit
that referenced
this pull request
Aug 15, 2024
#35693) …" (#35655) This reverts commit 7ae5ca5. The flakiness in #35653 is not caused by this PR. If you look at [the failure](https://btx.cloud.google.com/invocations/08f19e64-5934-4ed9-9f4c-e0d14e113360/targets/%2F%2Ftest%2Fextensions%2Ffilters%2Fnetwork%2Frbac:integration_test;config=a48d3689347bfb6aaa2bb9b4c87edaab1bb2d2c4710bec9b6690537c48f15140/log) (you can also find this by going to the issue and clicking the link), the failing test is `RoleBasedAccessControlNetworkFilterIntegrationTest.DelayDenied`. That test was added in #33875 and is still flaky at head. Signed-off-by: antoniovleonti <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Currently, if you only have stat prefixes configured in per-route config and not the base config, the stat prefix will be empty. this PR addresses that. --------- Signed-off-by: antoniovleonti <[email protected]> Signed-off-by: asingh-g <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…xy#35531)" (envoyproxy#35655) Revert "implement per-route override for rbac stat prefixes (envoyproxy#35531)" Causing //test/extensions/filters/network/rbac:integration_test to flakily time out. This reverts commit 751217c. Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: asingh-g <[email protected]>
duxin40
pushed a commit
to duxin40/envoy
that referenced
this pull request
Oct 15, 2024
…oxy#35531)… (envoyproxy#35693) …" (envoyproxy#35655) This reverts commit 7ae5ca5. The flakiness in envoyproxy#35653 is not caused by this PR. If you look at [the failure](https://btx.cloud.google.com/invocations/08f19e64-5934-4ed9-9f4c-e0d14e113360/targets/%2F%2Ftest%2Fextensions%2Ffilters%2Fnetwork%2Frbac:integration_test;config=a48d3689347bfb6aaa2bb9b4c87edaab1bb2d2c4710bec9b6690537c48f15140/log) (you can also find this by going to the issue and clicking the link), the failing test is `RoleBasedAccessControlNetworkFilterIntegrationTest.DelayDenied`. That test was added in envoyproxy#33875 and is still flaky at head. Signed-off-by: antoniovleonti <[email protected]> Signed-off-by: duxin40 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: implement per-route override for rbac stat prefixes
Additional Description: currently, if you only have stat prefixes configured in per-route config and not the base config, the stat prefix will be empty. this PR addresses that.
Risk Level: low
Testing: unit tested
Docs Changes: n/a
Release Notes: changelog updated