Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up doEndStream #35506

Merged

clean up doEndStream

7c4f974
Select commit
Loading
Failed to load commit list.
Merged

clean up doEndStream #35506

clean up doEndStream
7c4f974
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/macOS succeeded Jul 30, 2024 in 38m 42s

Envoy/macOS (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/macOS (pr/35506/main@7c4f974)

Check started by

Request (pr/35506/main@7c4f974)

antoniovleonti @antoniovleonti 7c4f974 #35506 merge main@3bf38b7

clean up doEndStream

Commit Message: clean up doEndStream
Additional Description: There are some variables that are only used if check_for_deferred_close is true. Move them to be inside the if (check_for_deferred_close) block.

Environment

Request variables

Key Value
ref 6e37034
sha 7c4f974
pr 35506
base-sha 3bf38b7
actor antoniovleonti @antoniovleonti
message clean up doEndStream...
started 1722360797.190361
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true