Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve substitution formatter parsing performance #35498

Merged
merged 12 commits into from
Aug 2, 2024

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-r…

a5a1e6c
Select commit
Loading
Failed to load commit list.
Merged

improve substitution formatter parsing performance #35498

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-r…
a5a1e6c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Release validation skipped Aug 2, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/35498/main@a5a1e6c)

wbpcode @wbpcode a5a1e6c #35498 merge main@5f26450

improve substitution formatter parsing performance

Commit Message: improve substitution formatter parsing performance
Additional Description:

See #35466

Previous parsing performance result:

---------------------------------------------------------------------------
Benchmark                                 Time             CPU   Iterations
---------------------------------------------------------------------------
BM_AccessLogFormatterSetup            75744 ns        75605 ns         9401

Latest parsing performance result:

---------------------------------------------------------------------------
Benchmark                                 Time             CPU   Iterations
---------------------------------------------------------------------------
BM_AccessLogFormatterSetup             8932 ns         8917 ns        78153

Risk Level: mid. Core code change.
Testing: unit.
Docs Changes: n/a.
Release Notes: no behavior change.
Platform Specific Features: n/a.

Environment

Request variables

Key Value
ref 69b396b
sha a5a1e6c
pr 35498
base-sha 5f26450
actor wbpcode @wbpcode
message improve substitution formatter parsing performance...
started 1722609632.333547
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true