Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_authz: add test for retry #35423

Merged
merged 1 commit into from
Jul 25, 2024
+46 −4
Merged

ext_authz: add test for retry #35423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ struct GrpcInitializeConfigOpts {
bool encode_raw_headers = false;
uint64_t timeout_ms = 300'000; // 5 minutes.
bool validate_mutations = false;
bool retry_5xx = false;
};

struct WaitForSuccessfulUpstreamResponseOpts {
Expand Down Expand Up @@ -93,6 +94,12 @@ class ExtAuthzGrpcIntegrationTest
*proto_config_.mutable_grpc_service()->mutable_timeout() =
Protobuf::util::TimeUtil::MillisecondsToDuration(opts.timeout_ms);

if (opts.retry_5xx) {
auto* retry_policy = proto_config_.mutable_grpc_service()->mutable_retry_policy();
retry_policy->set_retry_on("5xx");
retry_policy->mutable_num_retries()->set_value(2);
}

proto_config_.mutable_filter_enabled()->set_runtime_key("envoy.ext_authz.enable");
proto_config_.mutable_filter_enabled()->mutable_default_value()->set_numerator(100);
proto_config_.set_bootstrap_metadata_labels_key("labels");
Expand Down Expand Up @@ -205,11 +212,15 @@ class ExtAuthzGrpcIntegrationTest
response_ = codec_client_->makeRequestWithBody(headers, request_body_.toString());
}

void waitForExtAuthzRequest(const std::string& expected_check_request_yaml) {
void waitForExtAuthzRequest(const std::string& expected_check_request_yaml,
bool connection_already_established = false) {
if (!connection_already_established) {
AssertionResult result =
fake_upstreams_.back()->waitForHttpConnection(*dispatcher_, fake_ext_authz_connection_);
RELEASE_ASSERT(result, result.message());
}
AssertionResult result =
fake_upstreams_.back()->waitForHttpConnection(*dispatcher_, fake_ext_authz_connection_);
RELEASE_ASSERT(result, result.message());
result = fake_ext_authz_connection_->waitForNewStream(*dispatcher_, ext_authz_request_);
fake_ext_authz_connection_->waitForNewStream(*dispatcher_, ext_authz_request_);
RELEASE_ASSERT(result, result.message());

// Check for the validity of the received CheckRequest.
Expand Down Expand Up @@ -1112,6 +1123,37 @@ TEST_P(ExtAuthzGrpcIntegrationTest, TimeoutFailClosed) {
cleanup();
}

TEST_P(ExtAuthzGrpcIntegrationTest, Retry) {
if (clientType() == Grpc::ClientType::GoogleGrpc) {
GTEST_SKIP() << "Retry is only supported for Envoy gRPC";
}

GrpcInitializeConfigOpts opts;
opts.retry_5xx = true;
initializeConfig(opts);

// Use h1, set up the test.
setDownstreamProtocol(Http::CodecType::HTTP1);
HttpIntegrationTest::initialize();

// Start a client connection and request.
initiateClientConnection(0);

waitForExtAuthzRequest(expectedCheckRequest(Http::CodecType::HTTP1));
Http::TestResponseHeaderMapImpl response_headers{{":status", "503"}};
ext_authz_request_->encodeHeaders(response_headers, true);

// After the first failure, a second request is expected due to configured retries.
waitForExtAuthzRequest(expectedCheckRequest(Http::CodecType::HTTP1),
true /*connection_already_established*/);
sendExtAuthzResponse(Headers{}, Headers{}, Headers{}, Http::TestRequestHeaderMapImpl{},
Http::TestRequestHeaderMapImpl{}, Headers{}, Headers{}, Headers{},
Headers{});
waitForSuccessfulUpstreamResponse("200");

cleanup();
}

// Test behavior when validate_mutations is true & side stream provides invalid mutations (should
// respond downstream with HTTP 500 Internal Server Error).
TEST_P(ExtAuthzGrpcIntegrationTest, ValidateMutations) {
Expand Down