Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Add an option to set the UDP socket send and receive buffer sizes #35190

Merged
merged 2 commits into from
Jul 25, 2024

Address comments

042ee12
Select commit
Loading
Failed to load commit list.
Merged

mobile: Add an option to set the UDP socket send and receive buffer sizes #35190

Address comments
042ee12
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Release validation succeeded Jul 25, 2024 in 12m 13s

Mobile/Release validation (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/Release validation (pr/35190/main@042ee12)

Check started by

Request (pr/35190/main@042ee12)

fredyw @fredyw 042ee12 #35190 merge main@5e6897e

mobile: Add an option to set the UDP socket send and receive buffer sizes

This PR adds an option in the EngineBuilder to set the UDP socket send buffer size. By default it will use the same value as the one set in Chromium: https://source.chromium.org/chromium/chromium/src/+/main:net/quic/quic_session_pool.cc;l=790-793;drc=7f04a8e033c23dede6beae129cd212e6d4473d72

Risk Level: low
Testing: unit test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Environment

Request variables

Key Value
ref e078277
sha 042ee12
pr 35190
base-sha 5e6897e
actor fredyw @fredyw
message mobile: Add an option to set the UDP socket send and receive buffer sizes...
started 1721918305.137686
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true