Docs: Update access logs documentation to include equal operator. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
change title to something descriptive of the actual change (prefixed with "docs: ") |
ccaraman
changed the title
|
+1 |
mattklein123
approved these changes
Jan 11, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* fix test failures. * fixed mixer sha
jplevyak
referenced
this pull request
in jplevyak/envoy
Jan 22, 2020
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Adds unary interfaces (related to envoyproxy/envoy-mobile#118) which will call into the streaming interfaces under the hood. These are to be used as convenience convenience accessors for the common case of non-streaming requests, and will be added on Android as part of envoyproxy/envoy-mobile#119. This also removes `data` and `trailers` from `Request`, as the unary function will take care of this for unary requests, and streams will be expected to handle this through the `StreamEmitter`. The underlying implementation will look something like this: ```swift public func sendUnary(_ request: Request, body: Data?, trailers: [String: [String]] = [:], handler: ResponseHandler) { let emitter = self.startStream(with: request, handler: handler) if let body = body { emitter.sendData(body) } emitter.close(trailers: trailers) } ``` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Adds unary interfaces (related to envoyproxy/envoy-mobile#118) which will call into the streaming interfaces under the hood. These are to be used as convenience convenience accessors for the common case of non-streaming requests, and will be added on Android as part of envoyproxy/envoy-mobile#119. This also removes `data` and `trailers` from `Request`, as the unary function will take care of this for unary requests, and streams will be expected to handle this through the `StreamEmitter`. The underlying implementation will look something like this: ```swift public func sendUnary(_ request: Request, body: Data?, trailers: [String: [String]] = [:], handler: ResponseHandler) { let emitter = self.startStream(with: request, handler: handler) if let body = body { emitter.sendData(body) } emitter.close(trailers: trailers) } ``` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
liverbirdkte
referenced
this pull request
in liverbirdkte/envoy
Dec 2, 2022
Add support for setting cache size Signed-off-by: LeiZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy already supports the equal operator. This PR updates our documentation.