Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bumping bes timeout, making aync #34698

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jun 11, 2024

I'm hoping making it async will make bes failure upload a non-fail for CI

see https://bazel.build/reference/command-line-reference#flag--bes_upload_mode

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34698 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk changed the title CI: bumping bes timeout CI: bumping bes timeout, making aync Jun 11, 2024
@alyssawilk alyssawilk marked this pull request as ready for review June 11, 2024 19:58
Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk
Copy link
Contributor Author

I'm not sure if I'm falsely equating bes with bep in this case but the bazel team suggested the bes timeout change so I'm hoping bes non-synchronous helps too as the only relevant looking bep flag is experimental_build_event_upload_retry_minimum_delay= doesn't look super helpful

@alyssawilk alyssawilk marked this pull request as draft June 11, 2024 20:02
s
Signed-off-by: Alyssa Wilk <[email protected]>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk

BEP is the protocol BES is the stream of data that uses it - so they are ~interchangable in most contexts

@phlax
Copy link
Member

phlax commented Jun 11, 2024

/retest

@alyssawilk alyssawilk marked this pull request as ready for review June 12, 2024 12:14
@alyssawilk alyssawilk merged commit b37d9d2 into envoyproxy:main Jun 12, 2024
50 of 51 checks passed
@alyssawilk alyssawilk deleted the bes branch October 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants