Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: removing oauth_use_standard_max_age_value #34687

Merged

Conversation

alyssawilk
Copy link
Contributor

Fixes #31980

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34687 was opened by alyssawilk.

see: more, trace.

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #34687 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk force-pushed the oauth_use_standard_max_age_value branch 2 times, most recently from 7b69e69 to be2f89b Compare June 13, 2024 12:47
@alyssawilk alyssawilk force-pushed the oauth_use_standard_max_age_value branch from be4a9eb to 4a98e11 Compare June 17, 2024 12:38
@alyssawilk alyssawilk marked this pull request as ready for review June 17, 2024 15:45
@alyssawilk alyssawilk enabled auto-merge (squash) June 17, 2024 15:45
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alyssawilk alyssawilk merged commit a93137d into envoyproxy:main Jun 18, 2024
51 of 52 checks passed
Nealsoni00 pushed a commit to Nealsoni00/envoy that referenced this pull request Jun 18, 2024
antoniovleonti pushed a commit to antoniovleonti/envoy that referenced this pull request Jun 26, 2024
@alyssawilk alyssawilk deleted the oauth_use_standard_max_age_value branch October 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_oauth_use_standard_max_age_value deprecation
3 participants