Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiplexed upstream servers to half close the stream before the downstream #34461

Merged
merged 37 commits into from
Aug 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
7263c53
Allow multiplexed upstream servers to half close the stream before th…
yanavlasov May 31, 2024
fd17760
Address comments
yanavlasov Jun 21, 2024
723ed65
Merge branch 'main' into allow-upstream-half-close
yanavlasov Jun 21, 2024
1d8172c
Address comments
yanavlasov Jun 22, 2024
3ba7cc4
Clarify comment
yanavlasov Jun 24, 2024
6133efc
Reuse isHalfCloseEnabled callback
yanavlasov Jun 24, 2024
fcf2a76
Add stopDecoding
yanavlasov Jun 24, 2024
f24bc34
Merge branch 'main' into allow-upstream-half-close
yanavlasov Jun 25, 2024
0e881dc
Merge branch 'main' into allow-upstream-half-close
yanavlasov Jun 28, 2024
b7b746f
Fixing tests
yanavlasov Jul 26, 2024
af60f0b
Address post merge test failures
yanavlasov Jul 30, 2024
01ae68b
Merge branch 'main' into allow-upstream-half-close
yanavlasov Jul 30, 2024
1f269a4
Post merge fix
yanavlasov Jul 30, 2024
1b961df
Fix gcc build error
yanavlasov Jul 30, 2024
8ae88a0
WiP
yanavlasov Jul 30, 2024
d8aabba
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 2, 2024
2166fcb
Post merge fixes
yanavlasov Aug 2, 2024
e2deca2
WiP
yanavlasov Aug 8, 2024
9e9428f
Make ending filters in the middle of the filter chain work. p1
yanavlasov Aug 9, 2024
71ce1f0
Make encoding filters in the middle of the filter chain work. p2
yanavlasov Aug 9, 2024
68c807e
Update comments
yanavlasov Aug 12, 2024
9c308ba
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 12, 2024
2d8cb15
post merge fixes
yanavlasov Aug 12, 2024
e1c00d0
Update comment
yanavlasov Aug 12, 2024
018a3e4
Update comments
yanavlasov Aug 12, 2024
9a692f3
Address comments
yanavlasov Aug 15, 2024
bd30f81
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 15, 2024
b9948ab
Post merge fix
yanavlasov Aug 15, 2024
e224738
Update comment
yanavlasov Aug 15, 2024
e4ae6b4
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 16, 2024
d5320da
Fix docs
yanavlasov Aug 16, 2024
b804cb5
Disable upstream filter tests
yanavlasov Aug 16, 2024
4b305d9
Add coverage
yanavlasov Aug 16, 2024
9155e49
Address comments
yanavlasov Aug 21, 2024
49b6162
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 23, 2024
c02ac47
Add asserts
yanavlasov Aug 23, 2024
d965ff6
Merge branch 'main' into allow-upstream-half-close
yanavlasov Aug 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Post merge fix
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov committed Jul 30, 2024
commit 1f269a49c7544b15869cbea2cbde9d021b71a9c4
2 changes: 2 additions & 0 deletions source/common/quic/envoy_quic_utils.cc
Original file line number Diff line number Diff line change
@@ -90,6 +90,8 @@ quic::QuicRstStreamErrorCode envoyResetReasonToQuicRstError(Http::StreamResetRea
case Http::StreamResetReason::RemoteRefusedStreamReset:
case Http::StreamResetReason::RemoteReset:
IS_ENVOY_BUG("Remote reset shouldn't be initiated by self.");
case Http::StreamResetReason::Http1PrematureUpstreamHalfClose:
IS_ENVOY_BUG("H/1 premature response reset is not applicable to H/3.");
}

ENVOY_LOG_MISC(error, absl::StrCat("Unknown reset reason: ", reason));
2 changes: 1 addition & 1 deletion test/common/router/router_test.cc
Original file line number Diff line number Diff line change
@@ -3476,7 +3476,7 @@ TEST_F(RouterTest, NoRetryWithBodyLimitWithUpstreamHalfCloseEnabled) {
Buffer::OwnedImpl body("t");
router_->decodeData(body, false);
EXPECT_EQ(1U,
callbacks_.route_->route_entry_.virtual_cluster_.stats().upstream_rq_total_.value());
callbacks_.route_->virtual_host_.virtual_cluster_.stats().upstream_rq_total_.value());

Http::ResponseHeaderMapPtr response_headers(
new Http::TestResponseHeaderMapImpl{{":status", "200"}});