mobile: Wait until the Engine is ready before calling terminate #34287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
fredyw
force-pushed
the
wait_on_terminate
branch
2 times, most recently
from
f052c23 to
fc37924
Compare
|
/retest |
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @alyssawilk @abeyad |
abeyad
reviewed
May 22, 2024
| @@ -174,6 +177,7 @@ envoy_status_t InternalEngine::main(std::shared_ptr<Envoy::OptionsImplBase> opti | |||
| server_->api().randomGenerator()); | |||
| dispatcher_->drain(server_->dispatcher()); | |||
| callbacks_->on_engine_running_(); | |||
| engine_running_.Notify(); | |||
There was a problem hiding this comment.
should this be added before the on_engine_running callback, in case e.g. that on_engine_running callback happens to block?
abeyad
reviewed
May 22, 2024
| @@ -11,6 +11,9 @@ | |||
| #include "library/common/stats/utility.h" | |||
|
|
|||
| namespace Envoy { | |||
| namespace { | |||
| constexpr absl::Duration ENGINE_RUNNING_TIMEOUT = absl::Seconds(3); | |||
There was a problem hiding this comment.
out of curiosity, any idea how long average startup time is? I'm not sure what the typical range is
There was a problem hiding this comment.
It's typically really fast (less than 1 second). I put in 3 seconds and it's pretty arbitrary but I don't want it to wait indefinitely. I'm open to changing it to whatever timeout value that you think is more reasonable.
Signed-off-by: Fredy Wijaya <[email protected]>
abeyad
approved these changes
May 22, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Engineis not fully initialized, callingterminate()will cause an assertion failure.This PR adds a workaround to wait until the
Enginebefore proceeding to callterminate().Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile