Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Clean up .bazelrc #33612

Merged
merged 1 commit into from
Apr 17, 2024
Merged

mobile: Clean up .bazelrc #33612

merged 1 commit into from
Apr 17, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Apr 17, 2024

This PR removes unused mobile-asan-dev and mobile-tsan-dev since they don't really work. This PR also adds mobile-clang-tsan and mobile-clang-msan that can be executed locally.

Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33612 was opened by fredyw.

see: more, trace.

@fredyw fredyw marked this pull request as ready for review April 17, 2024 18:10
@fredyw
Copy link
Member Author

fredyw commented Apr 17, 2024

/assign @abeyad

@fredyw fredyw enabled auto-merge (squash) April 17, 2024 18:10
Signed-off-by: Fredy Wijaya <[email protected]>
@fredyw fredyw disabled auto-merge April 17, 2024 18:17
@fredyw fredyw enabled auto-merge (squash) April 17, 2024 18:17
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fredyw

@fredyw fredyw merged commit b26b02c into envoyproxy:main Apr 17, 2024
35 checks passed
@fredyw fredyw deleted the bazelrc_cleanup branch April 17, 2024 18:53
cainelli pushed a commit to cainelli/envoy that referenced this pull request Apr 18, 2024
This PR removes unused `mobile-asan-dev` and `mobile-tsan-dev` since they don't really work. This PR also adds `mobile-clang-tsan` and `mobile-clang-msan` that can be executed locally.

Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
This PR removes unused `mobile-asan-dev` and `mobile-tsan-dev` since they don't really work. This PR also adds `mobile-clang-tsan` and `mobile-clang-msan` that can be executed locally.

Risk Level: low
Testing: manual
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile


Signed-off-by: Fredy Wijaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants