Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update cel, absl, googleapis #32962

Closed
wants to merge 14 commits into from

Conversation

kyessenov
Copy link
Contributor

Commit Message: update CEL and its dependencies
Additional Description:
Risk Level: low
Testing: regression

Change-Id: I4b919b0aa8774458e4efe39d91603d28e6a649bc
Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I7797d12125dce79b9e770dea45732917c7e53f00
Change-Id: I0615ecb7f2ab892dd7cea0d4d565af05ad8bba93
Change-Id: Ie3a82096c5ccfd1212ec226d6c30e9434a6f2623
Signed-off-by: Kuat Yessenov <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 18, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #32962 was opened by kyessenov.

see: more, trace.

Change-Id: Ib203130db95cc09844d6139439aeeba5e99a4ee7
Signed-off-by: Kuat Yessenov <[email protected]>
@RyanTheOptimist
Copy link
Contributor

Looks like the mobile build is broken somehow?

@yanavlasov
Copy link
Contributor

It looks like a problem in uri_template_test.cc https://dev.azure.com/cncf/envoy/_build/results?buildId=165343&view=logs&j=8c169225-0ae8-53bd-947f-07cb81846cb5&t=d1a98671-b7ba-5fbf-f06c-ff337c010df4&l=701

Hopefully it would need gtest update too.

/wait

@yanavlasov yanavlasov self-assigned this Mar 25, 2024
Change-Id: I3a8d31480d66de9a95a0be716b69d4b98e2b5d6f
@kyessenov
Copy link
Contributor Author

I've tried to bump Google test - no luck. I'll fix the test directly and keep Google test bump - which seems like a good thing to have.

Change-Id: Ib58ea0d1a0f51cb0fd485c40b55a95e1d9963ffb
Change-Id: I835d26ec21a843fb4905413768a457bef3aca3a6
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
Copy link
Contributor Author

Undid googletest bump - that breaks something else, without fixing the build failure.

Change-Id: Ie03c2579368c269994cc1f7f6d396c7e57195d0d
Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I8cd2b6695998346ebeba67e6f4921ef6facb0d2a
Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I032714f533fb951e0abcfef36229a11f37e3655b
Signed-off-by: Kuat Yessenov <[email protected]>
@yanavlasov
Copy link
Contributor

Oh mad, this is difficult. It looks like for gcc failure we will need to patch protobuf. Not sure about the mobile build errors.

@soulxu
Copy link
Member

soulxu commented Apr 2, 2024

/wait

for CI

@phlax
Copy link
Member

phlax commented Apr 2, 2024

@kyessenov im thinking this should probably wait until after our next release as its getting close

Copy link

github-actions bot commented May 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 2, 2024
Change-Id: Icfb64c459d1580b08a53eb060ca157e44fb994e3
kyessenov added 2 commits May 6, 2024 21:03
Change-Id: Ie4e45d602161c3c1bef9b3aca797010628fdd18a
Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: If952fa80e46ce5f2b8733dc386b1548250cfce1b
Signed-off-by: Kuat Yessenov <[email protected]>
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label May 7, 2024
@kyessenov
Copy link
Contributor Author

The mobile failures appear to be in the base Envoy due to C++17 compiler flag. I think we can park this PR until mobile switches over to C++20 so that we don't have to bifurcate the code.

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 13, 2024
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants