Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetrytracer: Added support to configure a Dynatrace sampler #32598

Merged

improve unit test code coverage, correct member var naming

64b4b3d
Select commit
Loading
Failed to load commit list.
Merged

opentelemetrytracer: Added support to configure a Dynatrace sampler #32598

improve unit test code coverage, correct member var naming
64b4b3d
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/CC succeeded Feb 29, 2024 in 2m 56s

Mobile/CC (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/CC (pr/32598/main@64b4b3d)

Check started by

Request (pr/32598/main@64b4b3d)

samohte @samohte 64b4b3d #32598 merge main@dee4ff7

opentelemetrytracer: Added support to configure a Dynatrace sampler

Commit Message: Added support to configure a Dynatrace sampler

Additional Description: Given the OpenTracing deprecation, Dynatrace customers need a solution to migrate to the OpenTelememetry tracer in Envoy. We have contributed several features needed and the sampler is the last step. Please refer to the linked issue for more information/context.
Risk Level: Low
Testing: Unit, Integration, Manual
Docs Changes: Proto docs generated and verified locally
Release Notes: Added support to configure a Dynatrace sampler
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #32581]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref babb9969f058b88fc379a7a0dda7c71fe246e69b
sha 64b4b3d
pr 32598
base-sha dee4ff7
actor samohte @samohte
message opentelemetrytracer: Added support to configure a Dynatrace sampler...
started 1709186199.69908
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true