[bp/1.27] tracing: dd-trace-cpp v0.1.12 (#31526) #32015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <[email protected]>
|
Hi @Smeb, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
repokitteh-read-only
bot
removed
the
deps
|
Closed based on the comment in #32014 (maintainer of datadog library does not think we should backport the upgrade). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Istio and see issues with the datadog tracer in Envoy 1.27/1.28. We're opening this backport as we believe that the later version of the tracer library should resolve some (hopefully all) the issues we see.
As with the last backports I opened, I ran the unit tests locally (using
libc++).Commit Message: [bp/1.27] Datadog: tracing: dd-trace-cpp v0.1.12
Additional Description:
This is the backport of #31526
Risk Level: low
Testing: local unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes: #30957, #29354, and #31360.