Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access log: add support for %UPSTREAM_CONNECTION_ID% #31920

Merged

update usage.rst

87cad0a
Select commit
Loading
Failed to load commit list.
Merged

access log: add support for %UPSTREAM_CONNECTION_ID% #31920

update usage.rst
87cad0a
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS skipped Jan 24, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/31920/main@87cad0a)

deveshkandpal1224 @deveshkandpal1224 87cad0a #31920 merge main@6952f54

access log: add support for %UPSTREAM_CONNECTION_ID%

Add support to print %UPSTREAM_CONNECTION_ID% in access log. Currently, %CONNECTION_ID% is supported which prints downstream connection id in access log. Primary motivation for add this is to easily debug reuse of an existing connection while debugging communication between client -> server especially during draining of upstream envoy.

Commit Message: Add support for %UPSTREAM_CONNECTION_ID% in access log
Additional Description: Primary motivation for add this is to easily reason reuse of an existing connection while debugging communication between client -> server.
Risk Level: low
Testing: unit testing
Docs Changes: updated
Release Notes: updated

Environment

Request variables

Key Value
ref df375125f840d0a923c2bf3dde5d3bd31e583e96
sha 87cad0a
pr 31920
base-sha 6952f54
actor deveshkandpal1224 @deveshkandpal1224
message access log: add support for %UPSTREAM_CONNECTION_ID%...
started 1706065052.407297
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true