Fix a MSAN issue in ext_authz due to max_request_bytes_ change #31897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjun Xiang <[email protected]>
|
/assign @agrawroh |
TAOXUY
approved these changes
Jan 18, 2024
agrawroh
approved these changes
Jan 19, 2024
This change just initialize a variable to the default value. Not sure what test we need to add. |
ravenblackx
approved these changes
Jan 19, 2024
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Feb 6, 2024
…proxy#31897) Signed-off-by: Yanjun Xiang <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
|
backport added in #32211 @ravenblackx does this need to be backported further? |
|
Description says the problem was introduced in #31437 which is not on any earlier branches, so I think 1.29 is far enough. |
|
thanks - apologies for stupid qs - i was going through backports quickly we should probably use some convention like |
phlax
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Yanjun Xiang <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a MSAN issue in ext_authz due to recently commit: #31437.
The error indicates use-of-uniniialized value of max_request_bytes_.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]