-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth2: Add default expiry for RFC compliance #31499
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
/docs |
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/31499/docs/index.html The docs are (re-)rendered each time the CI |
/retest |
this appears to work as expected in local testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small API comment.
cc @derekargueta @mattklein123 oauth2 code-owners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm api
Assigning Matt as codeowner.
/assign @mattklein123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Oh, I think it needs a release note as well.
apologies for fp - im rebasing on this pr so it was to avoid the merge commit, pr commits were not changed |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Currently this filter does not work with Github - which would seem like one of the most likely use cases
This is a revival of #14625
Should fix #14542
Unblocks #31534
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]