ext_authz: fix body buffering feature on ExtAuthZ per-route filter #31437
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/31437/main@6f8f35f)
@agrawroh
6f8f35f
#31437
merge
main@5a15b9f
ext_authz: fix body buffering feature on ExtAuthZ per-route filter
Background
The with_request_body feature on per-route ExtAuthZ filter is not working as expected.
See: #31436
Changes
This PR fixes the body propagation when with_request_body is enabled on a per-route ExtAuthZ filter. Current implementation reads the flags for partial body and max bytes size only from the main HTTP filter and discards these configs on the per-route ExtAuthZ filter.
Commit Message: fix body buffering feature on ExtAuthZ per-route filter
Additional Description:add new private fields to hold the final state for the max bytes and whether partial body is allowed in the ExtAuthZ filter
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
Key | Value |
---|---|
ref | 27febf23ae00d39f387b0614fbdbf38d0c4016ab |
sha | 6f8f35f |
pr | 31437 |
base-sha | 5a15b9f |
actor | |
message | ext_authz: fix body buffering feature on ExtAuthZ per-route filter... |
started | 1704237901.399507 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:fd9ec000fdd72d5c5e4e4ef16db4f9103058779e |
mobile | envoyproxy/envoy-build-ubuntu:mobile-fd9ec000fdd72d5c5e4e4ef16db4f9103058779e |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 29 |
patch | 0 |
dev | true |