Make grpc_http1_reverse_bridge return HTTP 200. #31047
Merged
CI (Envoy) / Mobile/CC
skipped
Jan 16, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/31047/main@1ee6391)
1ee6391 
#31047 merge main@5eaffad
Make grpc_http1_reverse_bridge return HTTP 200.
gRPC clients expect that request status will be communicated using the gRPC status header, and that HTTP status for responses should always be 200 for properly behaving servers.
This commit updates the grpc_http1_reverse_bridge to follow this behavior.
Testing: Tested manually with grpcurl.
Environment
Request variables
| Key | Value |
|---|---|
| ref | 38f94a1ddca3f9fad7a93d35939857e8674901ae |
| sha | 1ee6391 |
| pr | 31047 |
| base-sha | 5eaffad |
| actor | @hq6 |
| message | Make grpc_http1_reverse_bridge return HTTP 200.... |
| started | 1705430272.368845 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 30 |
| patch | 0 |
| dev | true |
Loading