mobile: Add initial unit tests for jni_utility.(h|cc) #30849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR sets up an initial infrastructure for writing unit tests for `jni_utility.(h|cc)`. Signed-off-by: Fredy Wijaya <[email protected]>
fredyw
force-pushed
the
jni_utility_test
branch
from
71a1cf8 to
098ca39
Compare
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @abeyad |
abeyad
approved these changes
Nov 13, 2023
| // `test/java/io/envoyproxy/envoymobile/jni/JniUtilityTest.java` unit tests. | ||
|
|
||
| extern "C" JNIEXPORT jbyteArray JNICALL | ||
| Java_io_envoyproxy_envoymobile_jni_JniUtilityTest_protoJavaByteArrayConversion(JNIEnv* env, jclass, |
There was a problem hiding this comment.
so for every JNI method we want to test, we'll need a native test method in this file that does the similar to the function bodyhere?
There was a problem hiding this comment.
Yeah. This is how we can call those functions from Java/Kotlin.
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Nov 13, 2023
This PR sets up an initial infrastructure for writing unit tests for `jni_utility.(h|cc)`. Signed-off-by: Fredy Wijaya <[email protected]> Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
jni_utility.(h|cc)did not have any unit tests, which would make refactoring that file a bit risky. This PR sets up an initial infrastructure for writing unit tests forjni_utility.(h|cc)as well as adds an example unit test, so that we can slowly add unit tests for the functions defined in that file as well as requiring unit tests for future changes to that file.Risk Level: low (adding unit tests only)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile