Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var to force docker save #30502

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

keithmattix
Copy link
Contributor

Couldn't see another way to make docker export to tarballs without needlessly setting a dummy DOCKER_PASSWORD

phlax
phlax previously approved these changes Oct 26, 2023
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, altho i confess im no less confused if this fixes 8/

i would like to get final confirmation it does before landing

/wait

Signed-off-by: Keith Mattix II <[email protected]>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @keithmattix

apologies for the confusion

@phlax phlax enabled auto-merge (squash) October 26, 2023 16:27
@phlax phlax merged commit 6cf211b into envoyproxy:main Oct 26, 2023
@keithmattix
Copy link
Contributor Author

keithmattix commented Oct 27, 2023

Need to cherry-pick to 1.26 and 1.27 and 1.28

@keithmattix keithmattix deleted the docker-save-var branch October 27, 2023 14:34
keithmattix added a commit to keithmattix/envoy that referenced this pull request Oct 27, 2023
keithmattix added a commit to keithmattix/envoy that referenced this pull request Oct 27, 2023
keithmattix added a commit to keithmattix/envoy that referenced this pull request Oct 27, 2023
phlax pushed a commit that referenced this pull request Oct 27, 2023
phlax pushed a commit that referenced this pull request Oct 27, 2023
phlax pushed a commit that referenced this pull request Oct 27, 2023
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Sean Killeen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants