Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump com_google_absl -> 20230802.1 #30394

Closed

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Fix #29731

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 23, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #30394 was opened by dependency-envoy[bot].

see: more, trace.

@phlax
Copy link
Member

phlax commented Oct 23, 2023

passes everything apart from the hot restart test

INFO: From Action external/envoy_api/envoy/service/ext_proc/v3/external_processor.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/envoy_api/external/envoy_api: warning: directory does not exist.
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingFile.c.o):(function initializeProfileForContinuousMode: .text.initializeProfileForContinuousMode+0x26): relocation R_X86_64_REX_GOTPCRELX out of range: 2152472676 is not in [-2147483648, 2147483647]; references __llvm_profile_counter_bias_default
>>> referenced by InstrProfilingFile.c
>>> defined in /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingFile.c.o)
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
ERROR: /source/test/integration/BUILD:343:21: Linking test/integration/hotrestart_main failed: (Exit 1): clang-14 failed: error executing command (from target //test/integration:hotrestart_main) 
  (cd /build/bazel_root/base/execroot/envoy && \
  exec env - \
    BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
    BAZEL_FAKE_SCM_REVISION=e3b4a6e9570da15ac1caffdded17a8bebdc7dfc9 \
    BAZEL_LINKLIBS=-l%:libstdc++.a \
    BAZEL_LINKOPTS=-lm \
    BAZEL_USE_LLVM_NATIVE_COVERAGE=1 \
    CC=clang \
    CXX=clang++ \
    CXXFLAGS='-stdlib=libc++' \
    GCOV=llvm-profdata \
    LDFLAGS='-stdlib=libc++' \
    PATH=/usr/sbin:/usr/bin:/sbin:/bin:/opt/llvm/bin \
    PWD=/proc/self/cwd \
  /opt/llvm/bin/clang-14 @bazel-out/k8-fastbuild/bin/test/integration/hotrestart_main-2.params)
# Configuration: 49bdde30bac6553e401ca8fa2b87eb54d0ad323c6aab44a7e5b0b2019c063044
# Execution platform: @envoy_build_tools//toolchains:rbe_linux_clang_libcxx_platform
INFO: Elapsed time: 1551.005s, Critical Path: 390.42s
INFO: 28325 processes: 3442 remote cache hit, 17126 internal, 7757 remote.
//test/integration:run_envoy_test           

https://dev.azure.com/cncf/envoy/_build/results?buildId=153437&view=logs&s=4f7d954b-a765-565f-91a2-c04870dab43f

cc @ravenblackx

phlax added a commit to phlax/envoy that referenced this pull request Oct 24, 2023
While this may slow builds down a little and result in slightly
larger debug builds, it should reduce the size of production bins.

Adding here to unblock envoyproxy#30394 which has a related issue.

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the dependency/bazel/com_google_absl/20230802.1 branch from 0e6064f to 30cfb5e Compare October 24, 2023 18:01
phlax added a commit to phlax/envoy that referenced this pull request Oct 24, 2023
While this may slow builds down a little and result in slightly
larger debug builds, it should reduce the size of production bins.

Adding here to unblock envoyproxy#30394 which has a related issue.

Signed-off-by: Ryan Northey <[email protected]>
@ravenblackx
Copy link
Contributor

Did you try out any of the other possible workarounds we found to the R_X86_64_REX_GOTPCRELX out of range: 2152472676 is not in [-2147483648, 2147483647] problem?

@phlax
Copy link
Member

phlax commented Oct 26, 2023

Did you try out any of the other possible workarounds

no, i didnt circle back to this yet - but you can PR to the branch

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale stalebot believes this issue/PR has not been touched recently and removed stale stalebot believes this issue/PR has not been touched recently labels Nov 25, 2023
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 31, 2023
@phlax phlax force-pushed the dependency/bazel/com_google_absl/20230802.1 branch from 30cfb5e to 583adc1 Compare January 4, 2024 20:59
@phlax
Copy link
Member

phlax commented Jan 4, 2024

closing in favour of #31456

@phlax phlax closed this Jan 4, 2024
@phlax phlax deleted the dependency/bazel/com_google_absl/20230802.1 branch January 4, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available com_google_absl: 20230802.1 (current: c8b33b0)
3 participants