address: use resolveProtoAddress to resolve listener addresses #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henna Huang <[email protected]>
hennna
commented
Apr 10, 2018
| Network::Address::IpVersion::v4); | ||
|
|
||
| EXPECT_CALL(listener_factory_, createListenSocket(_, _, true)); | ||
| manager_->addOrUpdateListener(parseListenerFromV2Yaml(yaml), true); |
There was a problem hiding this comment.
This doesn't test that the resolved address matches what is expected. Is that necessary?
There was a problem hiding this comment.
Can you use a mock resolver or something to ensure we're at least going through the resolutino process?
Signed-off-by: Henna Huang <[email protected]>
dnoe
previously approved these changes
Apr 11, 2018
| @@ -123,6 +127,13 @@ class ListenerManagerImplWithRealFiltersTest : public ListenerManagerImplTest { | |||
| } | |||
| }; | |||
|
|
|||
| class MockAddressResolver : public Network::Address::Resolver { | |||
There was a problem hiding this comment.
test nit: I would move this into the common mocks as it is generally useful
There was a problem hiding this comment.
thanks for the review. done.
| Network::Address::IpVersion::v4); | ||
|
|
||
| MockAddressResolver mock_resolver; | ||
| EXPECT_CALL(mock_resolver, name()).WillRepeatedly(Return("envoy.mock.resolver")); |
There was a problem hiding this comment.
I would probably just setup a default ON_CALL in the mock for this one. (EXPECT_CALL/WillRepeatedly is a bit of an anti-pattern)
Signed-off-by: Henna Huang <[email protected]>
Signed-off-by: Henna Huang <[email protected]>
dnoe
approved these changes
Apr 12, 2018
mattklein123
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henna Huang [email protected]
title: Use resolveProtoAddress to resolve listener addresses
Description:
In #1835, support for synchronous address resolvers and upstream address resolution were added. This PR extends support to resolving listener addresses.
Risk Level: Low
Testing:
Existing tests pass.
listener_impl test cases added.
Docs Changes:
n/a
Release Notes:
n/a