[quic]impose a limit on the number of connection migrations #30109
Conversation
Signed-off-by: Renjie Tang <[email protected]>
|
/assign @RyanTheOptimist |
Signed-off-by: Renjie Tang <[email protected]>
There was a problem hiding this comment.
Modulo a request for a comment, this looks good. But I do have a question. The PR descriptions mentions:
Risk Level: Low. Can be turned off via num_timeouts_to_trigger_port_migration proto
But that turns off connection migration, it does not turn of the new behavior in this PR, right?
Signed-off-by: Renjie Tang <[email protected]>
Yes, the proto turns off connection migration as a whole. I put it there so that ppl know how to disable this feature in case anything goes wrong. |
|
/retest |
Commit Message: Limit the max number of connection migrations to 5.
Additional Description: This prevents too many new sockets being created.
Risk Level: Low. Can be turned off via num_timeouts_to_trigger_port_migration proto
Testing: integration test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a