Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/tools: Add tarball unpacker #29899

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 2, 2023

This removes the need for using download_toplevel and having to use a brittle/fixed path when unpacking outputs, you provide a bazel target to output to a directory.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #29899 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 2, 2023

this will conflict with #29887 - pref that lands first

@phlax phlax force-pushed the tarball-unpacker branch 3 times, most recently from 40cb786 to 69b473d Compare October 2, 2023 14:04
@phlax phlax force-pushed the tarball-unpacker branch 6 times, most recently from 3c95cec to 62df6fa Compare October 2, 2023 14:44
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
@phlax phlax force-pushed the tarball-unpacker branch from 62df6fa to 27b19f8 Compare October 2, 2023 14:53
@phlax phlax merged commit 2a0f265 into envoyproxy:main Oct 2, 2023
119 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Oct 3, 2023
phlax added a commit to phlax/envoy that referenced this pull request Oct 3, 2023
phlax added a commit that referenced this pull request Oct 3, 2023
Signed-off-by: phlax <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Oct 3, 2023
Signed-off-by: phlax <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants