Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets an oghttp2 option in ClientHttp2Options. #29629

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

birenroy
Copy link
Contributor

Commit Message: Sets an oghttp2 option in ClientHttp2Options.
Additional Description:
Risk Level: low
Testing: ran unit and integration tests
Docs Changes:
Release Notes:
Platform Specific Features:
Runtime guard: existing envoy_reloadable_features_http2_use_oghttp2

@birenroy
Copy link
Contributor Author

/assign @alyssawilk

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to think we should regression test this. If you want to land now to unblock canary and follow a follow-up issue for testing I'm Ok with that.
/wait-any

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given I'm out tomorrow, #29633

@alyssawilk alyssawilk merged commit 7acf6f6 into envoyproxy:main Sep 14, 2023
114 checks passed
@birenroy birenroy deleted the fix-http2-max-streams branch September 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants