Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: removing unused code #29610

Merged
merged 1 commit into from
Sep 14, 2023
Merged

grpc: removing unused code #29610

merged 1 commit into from
Sep 14, 2023

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Sep 13, 2023 •
edited
Loading

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@alyssawilk
grpc: removing unused code
f01b31f 
Signed-off-by: Alyssa Wilk <[email protected]>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #29610 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review September 14, 2023 11:57
phlax
phlax approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk (trusting that it is unused)

@alyssawilk alyssawilk enabled auto-merge (squash) September 14, 2023 12:38
@alyssawilk alyssawilk merged commit 8e7beb3 into envoyproxy:main Sep 14, 2023
@alyssawilk alyssawilk deleted the grpc branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @phlax