Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce coverage threshold for source/server #29589

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

ravenblackx
Copy link
Contributor

Commit Message: Reduce coverage threshold for source/server
Additional Description: This is a temporary reduction of a flaky coverage (#15239) because my recent changes have added some comment lines which aren't covered. #29585 is going to add a lot of coverage here.
Risk Level: None
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@repokitteh-read-only
Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk

🐱

Caused by: #29589 was opened by ravenblackx.

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ravenblackx

@phlax
Copy link
Member

phlax commented Sep 12, 2023

pushing through as it appears to be bad merge/permfail

@phlax phlax merged commit 2679c99 into envoyproxy:main Sep 12, 2023
@ravenblackx ravenblackx deleted the cov branch September 12, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants