repo reorg: move ext auth filters #2923
Conversation
Demonstrates common code across multiple filters. Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@alyssawilk and @envoyproxy/maintainers PTAL at the docs that I added. |
REPO_LAYOUT.md
Outdated
| * [bazel/](bazel/): Configuration for Envoy's use of [Bazel](https://bazel.build/). | ||
| * [ci/](ci/): Scripts used both during CI as well as to build Docker containers. | ||
| * [configs/](configs/): Example Envoy configurations. | ||
| * [docs/](docs/): Project level documentation is well as scripts for publishing final docs during |
There was a problem hiding this comment.
pinging this one. otherwise LGTM
There was a problem hiding this comment.
oops sorry missed it
REPO_LAYOUT.md
Outdated
|
|
||
| ## [source/](source/) | ||
|
|
||
| * [common/](source/[common/): Core Envoy code (not specific to extensions) that is also not |
REPO_LAYOUT.md
Outdated
| * [extensions/](source/extensions/): Extensions to the core Envoy code. The layout of this | ||
| directory is discussed in further detail below. | ||
| * [server/](source/server/): Code specific to running Envoy as a standalone server. E.g, | ||
| configuration, server startup, workers, etc. Overtime, the line between `common/` and `server/` |
REPO_LAYOUT.md
Outdated
| * Extension unit tests also match their source equivalents in [extensions/](test/extensions/). | ||
| * [integration/](test/integration/) holds end-to-end integration tests using roughly the real | ||
| Envoy server code, fake downstream clients, and fake upstream servers. Integration tests also | ||
| test some of the extensions found in the repository. |
There was a problem hiding this comment.
This doesn't seem ideal, aren't we going to push these into the extension specific dirs?
There was a problem hiding this comment.
This was my plan originally but @alyssawilk objected. Or maybe I misunderstood the objection @alyssawilk?
There was a problem hiding this comment.
We may - I'd asked we defer that until after the filter moves as I think there's a bunch of code which tests various filters, or tests core components (flow control) using extensions (various filters which buffer).
It's pretty non-trivial to tease these out.
There was a problem hiding this comment.
Also, we've been organizing our HTTP tests around codec so you can "easily" add a cors test for HTTP/2, HTTP, HTTP/2 upstream etc. I think we need an integration test rewrite to make it easier to have "the cors filter test" which runs the test for the varions combinations and permutations, rather than having 3 integration tests per filter which would be really crummy from a scaling perspective. I think if we do that refactor we could encourage folks to add new integration tests under their filter directories, and move the easy-to-tease-apart tests to their directories for reference implementations. Still not sure how we want to handle testing core features which require filters without implementing a bunch of fake test filters (which we could totally do, but don't have yet) so I think this will be a series of TODOs and follow-up PRs.
In the interim we could move the existing tests to http/common and network/common if we think it's worth an interim move.
There was a problem hiding this comment.
Yeah, I agree that more thinking is needed here. I would prefer that we not let "perfect be the enemy of the good" on this so I will add some aspirational text on where we would like this to go.
REPO_LAYOUT.md
Outdated
| * [docs/](docs/): Project level documentation is well as scripts for publishing final docs during | ||
| releases. | ||
| * [examples/](examples/): Larger Envoy examples using Docker and Docker Compose. | ||
| * [include/](include/): "Public" interface headers for "core" Envoy (not extensions). In general, |
There was a problem hiding this comment.
this is a bit confusingly phrased, given it includes the interfaces for major extensions, i.e. tcp proxying, http stream etc.
REPO_LAYOUT.md
Outdated
| * Extension unit tests also match their source equivalents in [extensions/](test/extensions/). | ||
| * [integration/](test/integration/) holds end-to-end integration tests using roughly the real | ||
| Envoy server code, fake downstream clients, and fake upstream servers. Integration tests also | ||
| test some of the extensions found in the repository. |
There was a problem hiding this comment.
We may - I'd asked we defer that until after the filter moves as I think there's a bunch of code which tests various filters, or tests core components (flow control) using extensions (various filters which buffer).
It's pretty non-trivial to tease these out.
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@htuch @alyssawilk updated PTAL |
Signed-off-by: Matt Klein <[email protected]>
Demonstrates common code across multiple filters.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A