Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel/coverage: Test remotely #29145

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 19, 2023

  • Use RBE for coverage tests
  • Switch coverage VMs to ms-hosted small

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the coverage-remote-tests branch from 7d34ff9 to 7f13138 Compare August 19, 2023 14:29
.azure-pipelines/pipelines.yml Outdated Show resolved Hide resolved
.bazelrc Outdated Show resolved Hide resolved
@phlax phlax force-pushed the coverage-remote-tests branch 2 times, most recently from 48fb416 to f4f4880 Compare August 19, 2023 16:21
@phlax phlax force-pushed the coverage-remote-tests branch 2 times, most recently from 3105642 to ddbadce Compare August 19, 2023 16:57
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the coverage-remote-tests branch from ddbadce to b0dfdfe Compare August 19, 2023 17:00
@phlax phlax enabled auto-merge (squash) August 19, 2023 17:07
Comment on lines +217 to +219
build:coverage --define=no_debug_info=1
build:coverage --linkopt=-Wl,-s
build:coverage --test_env=ENVOY_IP_TEST_VERSIONS=v4only
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will affect mobile - not sure if that is correct - we can move

@phlax
Copy link
Member Author

phlax commented Aug 19, 2023

/coverage

@repokitteh-read-only
Copy link

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/29145/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

🐱

Caused by: a #29145 (comment) was created by @phlax.

see: more, trace.

@phlax phlax merged commit 748d4d5 into envoyproxy:main Aug 21, 2023
phlax added a commit to phlax/envoy that referenced this pull request Aug 21, 2023
phlax added a commit that referenced this pull request Aug 21, 2023
phlax added a commit to phlax/envoy that referenced this pull request Aug 21, 2023
phlax added a commit that referenced this pull request Aug 22, 2023
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Aug 23, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit.
- Update to .bazelrc to envoyproxy/envoy#29145
- Update .bazelversion to envoyproxy/envoy#29057
- Update ci/run_envoy_docker.sh to envoyproxy/envoy#26049
- Update source/client/stream_decoder.cc to envoyproxy/envoy#29012
- Update build rules to support envoyproxy/envoy#29122

Signed-off-by: tomjzzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants