Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update the mobile_release workflow with the changed config options #29009

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

abeyad
Copy link
Contributor

@abeyad abeyad commented Aug 14, 2023

The mobile Bazel options were updated in
#28856, but the mobile_release workflow wasn't updated to use mobile-release-android. It was probably not caught by CI because it is a scheduled workflow that is run once a week as opposed to running on every PR.

The mobile Bazel options were updated in
envoyproxy#28856, but the mobile_release
workflow wasn't updated to use mobile-release-android. It was probably
not caught by CI because it is a manual workflow that is run once a week
as opposed to running on every PR.

Signed-off-by: Ali Beyad <[email protected]>
@abeyad abeyad enabled auto-merge (squash) August 14, 2023 15:15
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @abeyad

@abeyad abeyad disabled auto-merge August 14, 2023 17:45
@abeyad abeyad enabled auto-merge (squash) August 14, 2023 17:46
@abeyad
Copy link
Contributor Author

abeyad commented Aug 14, 2023

/retest

@abeyad abeyad merged commit e0b1b56 into envoyproxy:main Aug 14, 2023
@abeyad abeyad deleted the mobile_release_fix branch August 14, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants