Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhide config discovery option for network filters #28507

Closed

Conversation

ramaraochavali
Copy link
Contributor

#28407 implemented config discovery for network filters. This PR unhides it from api
Commit Message: unhide config discovery option for network filters
Additional Description: unhide config discovery option for network filters
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #28507 was opened by ramaraochavali.

see: more, trace.

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!
Looking at this comment, I'm not sure if the API should be changed now or wait until at least some integration tests are added to validate that it works. @ohadvano @kyessenov WDYT?

Copy link
Contributor

@ohadvano ohadvano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramaraochavali, that PR you mentioned only adjusts the interfaces to use config discovery but does not enable ECDS for network filters just yet. The follow up: #28477 adds implementation, integration test and adjusts API+docs. @adisuissa maybe you could replace Lizan as api reviewer as I see he's out?

@ramaraochavali
Copy link
Contributor Author

Ah. I thought it is implemented already. Will close this.

@ramaraochavali ramaraochavali deleted the fix/unhide_network branch July 20, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants