Set the downstream addresses early to prevent a logging segfault. #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Pane <[email protected]>
Signed-off-by: Brian Pane <[email protected]>
alyssawilk
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
My only question is if we think there should be some explicit boolean for "we have not yet done effective client IP calculation" so folks can explicitly tell if it has been done yet.
My inclination is to not worry about it since it will be done before any filter sees the headers.
|
Assuming Matt agrees since he LGTM'd and there's now tests and given it's a bugfix I'm inclined to merge now and do a follow-up if anyone cares about tracking IP state :-) |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Mar 14, 2018
Some absl::optional changes missed due to not being merged with envoyproxy#2688. Signed-off-by: Harvey Tuch <[email protected]>
htuch
added a commit
that referenced
this pull request
Mar 14, 2018
Some absl::optional changes missed due to not being merged with #2688. Signed-off-by: Harvey Tuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure that the local and remote downstream addresses are always set for a new
ActiveStream.Risk Level: Low
Testing: ran the unit and integration tests
Docs Changes: N/A
Release Notes: N/A
Fixes: #2780
Signed-off-by: Brian Pane [email protected]