Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WASM extension maintainer from PiotrSikora to mpwarres in OWNERS.md #25111

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Update WASM extension maintainer from PiotrSikora to mpwarres in OWNERS.md #25111

merged 4 commits into from
Jan 24, 2023

Conversation

RyanTheOptimist
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist commented Jan 23, 2023 •
edited
Loading

Update WASM extension maintainer from PiotrSikora to mpwarres in OWNERS.md

Signed-off-by: Ryan Hamilton [email protected]

@RyanTheOptimist
Copy link
Contributor Author

/assign @PiotrSikora

@RyanTheOptimist
Copy link
Contributor Author

@PiotrSikora, I understand this is your correct email address. But please let me know if there's a better address.

PiotrSikora
PiotrSikora reviewed Jan 23, 2023
View reviewed changes
OWNERS.md Outdated
@@ -67,7 +67,7 @@ The following extension maintainers have final say over the extensions mentioned
approve an extension PR, it will be merged by the maintainer on-call (or any other maintainer)
without further review.

* Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) (piotrsikora@google.com)
* Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) (psikora@aviatrix.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it should be [email protected]... but I no longer work on Wasm in Envoy and @mpwarres should replace me here on behalf of Google, since he took over those responsibilities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!

@PiotrSikora
Copy link
Contributor

/assign @mpwarres

@RyanTheOptimist
PiotrSikora -> mpwarres
157c16c 
Signed-off-by: Ryan Hamilton <[email protected]>
@RyanTheOptimist RyanTheOptimist changed the title Update email address for PiotrSikora in OWNERS.md Update WASM extension maintainer from PiotrSikora to mpwarres OWNERS.md Jan 23, 2023
@RyanTheOptimist RyanTheOptimist changed the title Update WASM extension maintainer from PiotrSikora to mpwarres OWNERS.md Update WASM extension maintainer from PiotrSikora to mpwarres in OWNERS.md Jan 23, 2023
@PiotrSikora
Copy link
Contributor

You should also update CODEOWNERS... and thanks for cleaning this up!

@RyanTheOptimist
CODEOWNERS
84bfd10 
Signed-off-by: Ryan Hamilton <[email protected]>
@RyanTheOptimist
Copy link
Contributor Author

You should also update CODEOWNERS...

Oh, good point! Thanks, I totally missed that.

and thanks for cleaning this up!

You're welcome. Happy to do it.

@RyanTheOptimist RyanTheOptimist enabled auto-merge (squash) January 23, 2023 21:33
PiotrSikora
PiotrSikora approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RyanTheOptimist
Copy link
Contributor Author

/assign @alyssawilk

@alyssawilk alyssawilk disabled auto-merge January 24, 2023 16:14
alyssawilk
alyssawilk reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo mpw approval

OWNERS.md
@@ -67,7 +67,7 @@ The following extension maintainers have final say over the extensions mentioned
approve an extension PR, it will be merged by the maintainer on-call (or any other maintainer)
without further review.

* Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) (piotrsikora@google.com)
* Michael Warres ([mpwarres] (https://github.com/mpwarres)) (mpw@google.com)
* Wasm
* Raúl Gutiérrez Segalés ([rgs1](https://github.com/rgs1)) ([email protected])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here, rgs1 removed himself from the pinterest extensions so we should probably remove entirely.

@RyanTheOptimist RyanTheOptimist merged commit 3087e24 into envoyproxy:main Jan 24, 2023
@mpwarres
Copy link
Contributor

Thanks, Ryan!

VishalDamgude pushed a commit to freshworks/envoy that referenced this pull request Feb 2, 2023
@RyanTheOptimist @VishalDamgude
Update WASM extension maintainer from PiotrSikora to mpwarres in OWNE…
ad2de94 
…RS.md (envoyproxy#25111)

Update WASM extension maintainer from PiotrSikora to mpwarres in OWNERS.md

Signed-off-by: Ryan Hamilton [email protected]
@mathetake mathetake mentioned this pull request Jun 4, 2023
Closed
@mathetake mathetake mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssawilk alyssawilk alyssawilk left review comments

@htuch htuch htuch approved these changes

@phlax phlax phlax approved these changes

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@mpwarres mpwarres mpwarres approved these changes

Assignees

@mpwarres mpwarres

@PiotrSikora PiotrSikora

@alyssawilk alyssawilk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RyanTheOptimist @PiotrSikora @mpwarres @phlax @htuch @alyssawilk