circleci: upload artifacts when coverage is below threshold #2502
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
test/run_envoy_bazel_coverage.sh
Outdated
| COVERAGE_VALUE=$(grep -Po 'lines: \K(\d|\.)*' "${COVERAGE_SUMMARY}") | ||
| COVERAGE_THRESHOLD=98.0 | ||
| COVERAGE_THRESHOLD=99.0 |
There was a problem hiding this comment.
Will revert this to 98.0 once I confirmed this actually works.
Signed-off-by: Lizan Zhou <[email protected]>
|
Yes we have coverage report: |
| @@ -73,6 +73,8 @@ time "${GCOVR}" --gcov-exclude="${GCOVR_EXCLUDE_REGEX}" \ | |||
| # run. | |||
| rm "${SRCDIR}"/test/coverage/BUILD | |||
|
|
|||
| [[ -z "${ENVOY_COVERAGE_DIR}" ]] || rsync -av "${COVERAGE_DIR}"/ "${ENVOY_COVERAGE_DIR}" | |||
There was a problem hiding this comment.
Why only if the coverage dir doesn't exist? I often (locally) use bazel.coverage to generate reports, and will run it a number of times to validate the coverage status as I make code changes. Usually it just clobbers the previous report as currently implemented. In this PR, I think it would silently fail to update.
There was a problem hiding this comment.
-z just check if the env ENVOY_COVERAGE_DIR is set, not checking if dir exists, if you run test/run_envoy_bazel_coverage.sh directly, this env var is not set.
…2502) * use destination service name in stackdriver metric label * add todo * fix merge mistake
Signed-off-by: Lizan Zhou [email protected]
Description:
Run rsync before checking threshold so CircleCI can pick up the coverage report.
Risk Level: Low
Testing: local tested
Docs Changes: N/A
Release Notes: N/A