Improve legibility of admin pages by indenting JSON. #2492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnoe
approved these changes
Jan 31, 2018
htuch
reviewed
Jan 31, 2018
| @@ -64,6 +64,7 @@ std::string MessageUtil::getJsonStringFromMessage(const Protobuf::Message& messa | |||
| // Setting this option makes debugging easier because it keeps field names consistent in JSON | |||
| // printouts. | |||
| json_options.preserve_proto_field_names = true; | |||
| json_options.add_whitespace = true; | |||
There was a problem hiding this comment.
This is used in various wire serializations. I think we probably don't want extra whitespace there universally. How about making this a bool arg that defaults false, and you can opt in stuff like admin pages?
|
I don't see the DCO signed-off-by, but maybe I'm missing something. It'll need to be in your commit message. |
|
Sounds good, will send an updated version.
…On Wed, Jan 31, 2018, 11:01 AM htuch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In source/common/protobuf/utility.cc
<#2492 (comment)>:
> @@ -64,6 +64,7 @@ std::string MessageUtil::getJsonStringFromMessage(const Protobuf::Message& messa
// Setting this option makes debugging easier because it keeps field names consistent in JSON
// printouts.
json_options.preserve_proto_field_names = true;
+ json_options.add_whitespace = true;
This is used in various wire serializations. I think we probably don't
want extra whitespace there universally. How about making this a bool arg
that defaults false, and you can opt in stuff like admin pages?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2492 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM_MpcCMJ4DI4jfwsaa38CJA49JSXUnks5tQLiIgaJpZM4R0eVq>
.
|
|
FYI this is being done already in #2449. cc @ramaraochavali |
|
This is covered in #2449, thanks for bringing it to my attention; closing this PR. |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* fix sd filter bugs * fix test * remove mesh uid change
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
) The `ubuntu-18.04` image has been deprecated: actions/runner-images#6002 May explain why our Linux CI jobs started being cancelled before even starting. https://envoyproxy.slack.com/archives/C02F93EEJCE/p1661181247759129 Signed-off-by: JP Simard <[email protected]>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
) The `ubuntu-18.04` image has been deprecated: actions/runner-images#6002 May explain why our Linux CI jobs started being cancelled before even starting. https://envoyproxy.slack.com/archives/C02F93EEJCE/p1661181247759129 Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve legibility of admin pages by indenting JSON.