-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: hints for using v4 dns to avoid 503 (#2478) #2488
Conversation
Can you merge master to pickup #2490? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending a fresh merge (I'd rather not force-merge anything but other folks are welcome to :-) )
configs/google_com_proxy.v2.yaml
Outdated
@@ -28,6 +28,9 @@ static_resources: | |||
- name: service_google | |||
connect_timeout: 0.25s | |||
type: LOGICAL_DNS | |||
# uncomment the following line if your environment don't have v6 network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: (As long as you have to merge master):
"Uncomment the following line if your environment doesn't have v6 network access or Envoy may try to talk to a v6 endpoint which will result in a 503 error."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: Yingyu Cheng <[email protected]>
Signed-off-by: Yingyu Cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add a YAML comment to the config file that might help someone who encounters v4/v6 dns problem in the future.
Risk Level
Low, fixing sample config
Testing
manual testing.
Environment: a machine don't have ipv6 network but can resolve v6 address of google
before
uncomment
dns_lookup_family: V4_ONLY
fix
#2478