Add DOWNSTREAM_LOCAL_ADDRESS header variable #2487
Conversation
| @@ -126,6 +126,12 @@ RequestInfoHeaderFormatter::RequestInfoHeaderFormatter(absl::string_view field_n | |||
| return RequestInfo::Utility::formatDownstreamAddressNoPort( | |||
| *request_info.downstreamRemoteAddress()); | |||
| }; | |||
| } else if (field_name == "ORIGINAL_DST" || | |||
There was a problem hiding this comment.
Do we need "ORIGINAL_DST"? Would prefer to only have one and the other is more common with the new layout.
|
I think ORiGin_dst is more in-line with the cluster type of the same meaning. It also better describes the content. |
I'm sorry I disagree. We already have precedent for this in the access log formatter and I would like to be consistent: https://github.com/envoyproxy/envoy/blob/master/source/common/access_log/access_log_formatter.cc#L234 You are forwarding the local address, which is useful either in the case of original_dst or not. Feel free to provide ample links in the docs to the original_dst filter, describe the scenario, etc. Also, if you add a "WITHOUT_PORT" option please also add it to the access log formatter (with tests) so we have parity. |
|
Ok, I will remove original_dst alias. |
mandarjog
force-pushed
the
original_dst
branch
3 times, most recently
from
a51e65b to
b07b504
Compare
mandarjog
changed the title
|
Can you merge master to pickup #2490? |
mandarjog
force-pushed
the
original_dst
branch
from
b07b504 to
1fda658
Compare
Adds ORIGINAL_DST header variable which is an alias for DOWNSTREAM_LOCAL_ADDRESS_WITHOUT_PORT. ORIGINAL_DST is the address that the client initially expected to reach. Signed-off-by: Mandar U Jog <[email protected]>
Add DOWNSTREAM_LOCAL_ADDRESS_WITHOUT_PORT to header_formatter and access_log_formatter. Signed-off-by: Mandar U Jog <[email protected]>
Signed-off-by: Mandar U Jog <[email protected]>
Signed-off-by: Mandar U Jog <[email protected]>
mandarjog
force-pushed
the
original_dst
branch
from
1fda658 to
f9a54aa
Compare
|
@mattklein123 Updated RAW_RELEASE_NOTES. |
Adds ORIGINAL_DST header variable which is an alias for
DOWNSTREAM_LOCAL_ADDRESS_WITHOUT_PORT.
ORIGINAL_DST is the address that the client initially expected to reach.
Signed-off-by: Mandar U Jog [email protected]
fixes #2484