Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Cleanups for docker compose #20777

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 12, 2022

Commit Message:

  • Update compose version 3.7 -> 3.8
  • prevent base images from starting when running examples
  • remove unnecessary network configs

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft April 12, 2022 05:47
@phlax phlax changed the title examples: Cleanups for docker compose [WIP] examples: Cleanups for docker compose Apr 12, 2022
- Update compose version `3.7` -> `3.8`
- prevent base images from starting when running examples
- remove unnecessary network configs

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the examples-base-image-nostart branch from 92728b6 to 70098a7 Compare April 12, 2022 07:15
@phlax phlax changed the title [WIP] examples: Cleanups for docker compose examples: Cleanups for docker compose Apr 12, 2022
@phlax phlax marked this pull request as ready for review April 12, 2022 07:15
@phlax phlax merged commit 33d25b8 into envoyproxy:main Apr 12, 2022
vehre-x41 pushed a commit to vehre-x41/envoy that referenced this pull request Apr 19, 2022
- Update compose version `3.7` -> `3.8`
- prevent base images from starting when running examples
- remove unnecessary network configs

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Andre Vehreschild <[email protected]>
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
- Update compose version `3.7` -> `3.8`
- prevent base images from starting when running examples
- remove unnecessary network configs

Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants