-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
router: Remove PathMatchType and PathMatchCriterion #20649
router: Remove PathMatchType and PathMatchCriterion #20649
Conversation
Signed-off-by: Toma Petkov <[email protected]>
Proposal to remove |
Signed-off-by: Toma Petkov <[email protected]>
/assign-from envoyproxy/envoy-maintainers |
envoyproxy/envoy-maintainers assignee is @mattklein123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall the history on this. It seems fine to remove. Thank you!
+1 |
hi there, this PR breaks our system, I think we need to reverse this PR if no strong opinion. TLDR we need this field to take a peek into how route selection works. Please see the original issue/PR for reference: #2531 |
Sure feel free to revert but please add comments/tests that make it clear this is used in private extensions so it doesn't get removed again. |
thanks. @adisuissa could you please revert this as we've discussed. |
This reverts commit 7014ce6.
…xy#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <[email protected]>
…#20797) * Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <[email protected]>
…xy#20649)" (envoyproxy#20797) * Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <[email protected]> Signed-off-by: Andre Vehreschild <[email protected]>
Signed-off-by: Toma Petkov <[email protected]>
…xy#20649)" (envoyproxy#20797) * Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Toma Petkov [email protected]
Commit Message: Remove PathMatchType enum and PathMatchCriterion class, as they aren't used anywhere.
Additional Description: PathMatchCriterion class is never instantiated anywhere, besides for inheritance and testing.
Risk Level: Low
Testing: Unit test (test/common/router)
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]