re: removing histograms, tweaking runtime access #19972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
jmarantz
previously approved these changes
Feb 15, 2022
| @@ -22,7 +22,8 @@ bool runtimeFeatureEnabled(absl::string_view feature) { | |||
| } | |||
|
|
|||
| uint64_t getInteger(absl::string_view feature, uint64_t default_value) { | |||
| ASSERT(absl::StartsWith(feature, "envoy.")); | |||
| ASSERT(absl::StartsWith(feature, "envoy.") || | |||
| absl::StartsWith(feature, "re2.")); | |||
There was a problem hiding this comment.
How did this work before?
There was a problem hiding this comment.
It used the singleton but didn't use the "approved" methods, but instead used the instance function runtime->getInteger() as a workaround to the guards I put in place to have people not do this :-(
Signed-off-by: Alyssa Wilk <[email protected]>
jmarantz
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of #19847