testing: make factory registries support injection #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Konradi <[email protected]>
Signed-off-by: Alex Konradi <[email protected]>
Don't de-register factories on shutdown since that's not necessary. Signed-off-by: Alex Konradi <[email protected]>
Signed-off-by: Alex Konradi <[email protected]>
There was a problem hiding this comment.
Cool stuff. Small nit. @alyssawilk FWIW I like this pattern of having an RAII guard around replacing statics for tests. I haven't looked at your other PR but maybe we can do this for that also somehow?
include/envoy/registry/registry.h
Outdated
| @@ -36,6 +36,17 @@ template <class Base> class FactoryRegistry { | |||
| } | |||
|
|
|||
| /** | |||
| * Replaces a factory by name. This method should only be used for testing purposes. | |||
| * @param factory is the factory to inject | |||
There was a problem hiding this comment.
nit: periods end of sentences here and below.
|
@mattklein123 I do have an RAII replacement for tests. It's the Singleton itself which isn't of limited scope, right? |
Signed-off-by: Alex Konradi <[email protected]>
|
@alyssawilk right, cool. Will look at the other PR. |
Make InjectFactory a friend of the FactoryRegistry class, and limit access to the testing functions by making them private. Signed-off-by: Alex Konradi <[email protected]>
Signed-off-by: Alex Konradi <[email protected]>
mattklein123
approved these changes
Oct 31, 2017
alyssawilk
approved these changes
Nov 1, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Changes makeEnvoyMap to work with not only a vector of pairs, but any map-like container type. Signed-off-by: Snow Pettersen <[email protected]> Risk Level: Low Testing: Existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Changes makeEnvoyMap to work with not only a vector of pairs, but any map-like container type. Signed-off-by: Snow Pettersen <[email protected]> Risk Level: Low Testing: Existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows factories to be injected into registries for testing purpoes.
Tangentially related to #1808
Risk Level: Low
Testing:
Ran the unit tests