release: 1.21 #19466

alyssawilk · 2022-01-10T19:45:46Z

Risk Level: low
Testing: lots
Docs Changes: indeed
Release Notes: also yes.

alyssawilk · 2022-01-10T19:46:19Z

docs/root/version_history/current.rst

 * json: switching from rapidjson to nlohmann/json. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.remove_legacy_json`` to false.
 * listener: destroy per network filter chain stats when a network filter chain is removed during the listener in place update.
-* quic: add back the support for IETF draft 29 which is guarded via ``envoy.reloadable_features.FLAGS_quic_reloadable_flag_quic_disable_version_draft_29``. It is off by default so Envoy only supports RFCv1 without flipping this runtime guard explicitly. Draft 29 is not recommended for use.


Took this out becasue quic doesn't need release notes yet, and advertising something we don't want folks to use seems silly.

Signed-off-by: Alyssa Wilk <[email protected]>

alyssawilk · 2022-01-11T13:39:06Z

please to ignore coverage failure - I'm sorting that out elsewhre

docs page here for your convenience:
https://storage.googleapis.com/envoy-pr/ac3f373/docs/version_history/current.html

adisuissa

Thanks for managing the release and cleaning up the docs.
Left one question.

docs/root/version_history/current.rst

adisuissa

Thanks!
Left a few comments.

docs/root/version_history/current.rst

adisuissa · 2022-01-11T15:04:14Z

RELEASES.md

-| 1.20.0  | 2021/09/30 | 2021/10/05 |   +5 days  | 2022/10/13  |
-| 1.21.0  | 2022/01/15 |            |            |             |
+| 1.20.0  | 2021/09/30 | 2021/10/05 |   +5 days  | 2022/10/05  |
+| 1.21.0  | 2022/01/15 | 2022/01/12 |   -3 days  | 2023/01/12  |


Does it need a new entry (1.22.0) now, or after the release is cut?
(per GOVERNANCE.md it seems after the release is cut, but I guess it can be added now).

Also, should there be a Release Manager for 2022 Q1 above?

yeah I think we add after the release is cut and we definitely want a release manager for Q1 - waiting for folks to get back to us sadly.

adisuissa · 2022-01-11T15:06:28Z

docs/root/version_history/current.rst

@@ -15,14 +15,13 @@ Minor Behavior Changes
 * bandwidth_limit: added :ref:`response trailers <envoy_v3_api_field_extensions.filters.http.bandwidth_limit.v3.BandwidthLimit.enable_response_trailers>` when request or response delay are enforced.
 * bandwidth_limit: added :ref:`bandwidth limit stats <config_http_filters_bandwidth_limit>` *request_enforced* and *response_enforced*.
 * dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false.


Suggested change

* dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false.

* dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>`. This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false.

adisuissa · 2022-01-11T15:10:23Z

docs/root/version_history/current.rst

 * json: switching from rapidjson to nlohmann/json. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.remove_legacy_json`` to false.
 * listener: destroy per network filter chain stats when a network filter chain is removed during the listener in place update.
-* quic: add back the support for IETF draft 29 which is guarded via ``envoy.reloadable_features.FLAGS_quic_reloadable_flag_quic_disable_version_draft_29``. It is off by default so Envoy only supports RFCv1 without flipping this runtime guard explicitly. Draft 29 is not recommended for use.
-* router: take elapsed time into account when setting the x-envoy-expected-rq-timeout-ms header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
+* router: take elapsed time into account when setting the 11x-envoy-expected-rq-timeout-ms header11 for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.


Suggested change

* router: take elapsed time into account when setting the 11x-envoy-expected-rq-timeout-ms header11 for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.

* router: take elapsed time into account when setting the ``x-envoy-expected-rq-timeout-ms`` header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.

adisuissa · 2022-01-11T15:13:34Z

docs/root/version_history/current.rst

 * json: switching from rapidjson to nlohmann/json. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.remove_legacy_json`` to false.
 * listener: destroy per network filter chain stats when a network filter chain is removed during the listener in place update.
-* quic: add back the support for IETF draft 29 which is guarded via ``envoy.reloadable_features.FLAGS_quic_reloadable_flag_quic_disable_version_draft_29``. It is off by default so Envoy only supports RFCv1 without flipping this runtime guard explicitly. Draft 29 is not recommended for use.
-* router: take elapsed time into account when setting the x-envoy-expected-rq-timeout-ms header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
+* router: take elapsed time into account when setting the 11x-envoy-expected-rq-timeout-ms header11 for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
 * stream_info: response code details with empty space characters (' ', '\t', '\f', '\v', '\n', '\r') is not accepted by the ``setResponseCodeDetails()`` API.


The backslashes do not appear in the rendered doc (https://storage.googleapis.com/envoy-pr/ac3f373/docs/version_history/current.html).
Should this be \\?

Suggested change

* stream_info: response code details with empty space characters (' ', '\t', '\f', '\v', '\n', '\r') is not accepted by the ``setResponseCodeDetails()`` API.

* stream_info: response code details with empty space characters (' ', '\\t', '\\f', '\\v', '\\n', '\\r') is not accepted by the ``setResponseCodeDetails()`` API.

adisuissa · 2022-01-11T15:18:51Z

docs/root/version_history/current.rst

@@ -92,7 +91,7 @@ New Features
 * matcher: added support for *xds.type.matcher.v3.IPMatcher* IP trie matching.
 * oauth filter: added :ref:`cookie_names <envoy_v3_api_field_extensions.filters.http.oauth2.v3.OAuth2Credentials.cookie_names>` to allow overriding (default) cookie names (``BearerToken``, ``OauthHMAC``, and ``OauthExpires``) set by the filter.
 * oauth filter: setting IdToken and RefreshToken cookies if they are provided by Identity provider along with AccessToken.


Suggested change

* oauth filter: setting IdToken and RefreshToken cookies if they are provided by Identity provider along with AccessToken.

* oauth filter: setting ``IdToken`` and ``RefreshToken`` cookies if they are provided by Identity provider along with ``AccessToken``.

adisuissa · 2022-01-11T15:22:16Z

docs/root/version_history/current.rst

@@ -92,7 +91,7 @@ New Features
 * matcher: added support for *xds.type.matcher.v3.IPMatcher* IP trie matching.
 * oauth filter: added :ref:`cookie_names <envoy_v3_api_field_extensions.filters.http.oauth2.v3.OAuth2Credentials.cookie_names>` to allow overriding (default) cookie names (``BearerToken``, ``OauthHMAC``, and ``OauthExpires``) set by the filter.
 * oauth filter: setting IdToken and RefreshToken cookies if they are provided by Identity provider along with AccessToken.
-* perf: added support for [Perfetto](https://perfetto.dev) performance tracing.
+* perf: added support for `Perfetto <https://perfetto.dev>`_ performance tracing.
 * router: added support for the :ref:`config_http_conn_man_headers_x-forwarded-host` header.
 * stats: added text_readouts query parameter to prometheus stats to return gauges made from text readouts.


Cannot add a comment in the correct line, but line 79 should be:
* dns_resolver: added :ref:filter_unroutable_families<envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.filter_unroutable_families> to the c-ares DNS resolver.

Instead of:
* dns_resolver: added :ref:use_resolvers_as_fallback<envoy_v3_api_field_extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig.filter_unroutable_families> to the c-ares DNS resolver.

adisuissa · 2022-01-11T15:26:34Z

docs/root/version_history/current.rst

 * json: switching from rapidjson to nlohmann/json. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.remove_legacy_json`` to false.
 * listener: destroy per network filter chain stats when a network filter chain is removed during the listener in place update.
-* quic: add back the support for IETF draft 29 which is guarded via ``envoy.reloadable_features.FLAGS_quic_reloadable_flag_quic_disable_version_draft_29``. It is off by default so Envoy only supports RFCv1 without flipping this runtime guard explicitly. Draft 29 is not recommended for use.
-* router: take elapsed time into account when setting the x-envoy-expected-rq-timeout-ms header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
+* router: take elapsed time into account when setting the 11x-envoy-expected-rq-timeout-ms header11 for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
 * stream_info: response code details with empty space characters (' ', '\t', '\f', '\v', '\n', '\r') is not accepted by the ``setResponseCodeDetails()`` API.
 * upstream: fixed a bug where auto_config didn't work for wrapped TLS sockets (e.g. if proxy proto were configured for TLS).



Sorry for the misplaced comment.
Line 49 should be:
* http: removed ``envoy.reloadable_features.dont_add_content_length_for_bodiless_requests`` deprecation and legacy code paths.

Instead of:
* http: removed ``envoy.reloadable_features.dont_add_content_length_for_bodiless_requests deprecation`` and legacy code paths.

adisuissa · 2022-01-11T15:29:12Z

docs/root/version_history/current.rst

 * http: envoy will now proxy 102 and 103 headers from upstream, though as with 100s only the first 1xx response headers will be sent. This behavioral change by can temporarily reverted by setting runtime guard ``envoy.reloadable_features.proxy_102_103`` to false.
 * http: usage of the experimental matching API is no longer guarded behind a feature flag, as the corresponding protobuf fields have been marked as WIP.
-* http: when envoy run out of ``max_requests_per_connection``, it will send an HTTP/2 "shutdown nofitication" (GOAWAY frame with max stream ID) and go to a default grace period of 5000 milliseconds (5 seconds) if ``drain_timeout`` is not specified. During this grace period, envoy will continue to accept new streams. After the grace period, a final GOAWAY is sent and envoy will start refusing new streams. However before bugfix, during the grace period, every time a new stream is received, old envoy will always send a "shutdown notification" and restart drain again which actually causes the grace period to be extended and is no longer equal to ``drain_timeout``.
+* http: when a downstream connection hits a configured ``max_requests_per_connection``, it will send an HTTP/2 "shutdown nofitication" (GOAWAY frame with max stream ID) and go to a default grace period of 5000 milliseconds (5 seconds) if :ref:`drain_timeout <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.drain_timeout>` is not specified. During this grace period, envoy will continue to accept new streams. After the grace period, a final GOAWAY is sent and envoy will start refusing new streams. However before bugfix, during the grace period, every time a new stream is received, envoy would restart the drain which caused the grace period to be extended and so longer than the configured drain timeout.


Suggested change

* http: when a downstream connection hits a configured ``max_requests_per_connection``, it will send an HTTP/2 "shutdown nofitication" (GOAWAY frame with max stream ID) and go to a default grace period of 5000 milliseconds (5 seconds) if :ref:`drain_timeout <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.drain_timeout>` is not specified. During this grace period, envoy will continue to accept new streams. After the grace period, a final GOAWAY is sent and envoy will start refusing new streams. However before bugfix, during the grace period, every time a new stream is received, envoy would restart the drain which caused the grace period to be extended and so longer than the configured drain timeout.

* http: when a downstream connection hits a configured ``max_requests_per_connection``, it will send an HTTP/2 "shutdown notification" (GOAWAY frame with max stream ID) and go to a default grace period of 5000 milliseconds (5 seconds) if :ref:`drain_timeout <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.drain_timeout>` is not specified. During this grace period, envoy will continue to accept new streams. After the grace period, a final GOAWAY is sent and envoy will start refusing new streams. However before the bugfix, during the grace period, every time a new stream is received, envoy would restart the drain which caused the grace period to be extended, making it longer than the configured drain timeout.

Signed-off-by: Alyssa Wilk <[email protected]>

alyssawilk · 2022-01-11T21:01:40Z

/wait bad merge

Signed-off-by: Alyssa Wilk <[email protected]>

alyssawilk · 2022-01-11T21:22:12Z

it's getting there!
latest version here: https://storage.googleapis.com/envoy-pr/2043334/docs/version_history/current.html
if @envoyproxy/envoy-maintainers could take a look, many reviews make for few typos :-P

adisuissa

Looked at it again, LGTM.
2 nits (sorry again for commenting like this again, but cannot get github UI to add comments on these lines):

Line 85:
Before: * http: added support for %REQUESTED_SERVER_NAME% to extract SNI as a custom header.
After: * http: added support for ``%REQUESTED_SERVER_NAME%`` to extract SNI as a custom header.

Line 86:
Before: * http: added support for %VIRTUAL_CLUSTER_NAME% to extract the matched Virtual Cluster name as a custom header.
After: * http: added support for ``%VIRTUAL_CLUSTER_NAME%`` to extract the matched Virtual Cluster name as a custom header.

Signed-off-by: Alyssa Wilk <[email protected]>

adisuissa

One more comments from latest main merge :)

adisuissa · 2022-01-12T14:02:06Z

docs/root/version_history/current.rst

 * json: switching from rapidjson to nlohmann/json. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.remove_legacy_json`` to false.
 * listener: destroy per network filter chain stats when a network filter chain is removed during the listener in place update.
-* quic: add back the support for IETF draft 29 which is guarded via ``envoy.reloadable_features.FLAGS_quic_reloadable_flag_quic_disable_version_draft_29``. It is off by default so Envoy only supports RFCv1 without flipping this runtime guard explicitly. Draft 29 is not recommended for use.
-* router: take elapsed time into account when setting the x-envoy-expected-rq-timeout-ms header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
+* router: take elapsed time into account when setting the ``x-envoy-expected-rq-timeout-ms header`` for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
 * stateful session http filter: added :ref:`stateful session http filter <config_http_filters_stateful_session>`.


Should this be under New Features?

alyssawilk · 2022-01-12T14:44:40Z

Final docs here: https://storage.googleapis.com/envoy-pr/93d993e/docs/version_history/current.html

Signed-off-by: Alyssa Wilk <[email protected]>

adisuissa

LGTM, thanks @alyssawilk!

Risk Level: low Testing: lots Docs Changes: indeed Release Notes: also yes. Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Josh Perry <[email protected]>

alyssawilk commented Jan 10, 2022

View reviewed changes

release: 1.21

eab6324

Signed-off-by: Alyssa Wilk <[email protected]>

alyssawilk force-pushed the relnotes branch from 5bcaf9e to eab6324 Compare January 10, 2022 20:03

alyssawilk assigned phlax and adisuissa Jan 11, 2022

adisuissa reviewed Jan 11, 2022

View reviewed changes

docs/root/version_history/current.rst Show resolved Hide resolved

adisuissa requested changes Jan 11, 2022

View reviewed changes

alyssawilk added 2 commits January 11, 2022 10:49

fantastic comments!

cfb51d8

Signed-off-by: Alyssa Wilk <[email protected]>

Merge branch 'main' into relnotes

ad0d11d

Signed-off-by: Alyssa Wilk <[email protected]>

repokitteh-read-only bot added the waiting label Jan 11, 2022

fix bad merge

5c14b1b

Signed-off-by: Alyssa Wilk <[email protected]>

repokitteh-read-only bot removed the waiting label Jan 11, 2022

adisuissa reviewed Jan 12, 2022

View reviewed changes

alyssawilk added 2 commits January 12, 2022 08:46

comments

6d931b8

Signed-off-by: Alyssa Wilk <[email protected]>

Merge branch 'main' into relnotes

cfa25a1

Signed-off-by: Alyssa Wilk <[email protected]>

alyssawilk modified the milestones: 1.22.0, 1.21.0 Jan 12, 2022

adisuissa reviewed Jan 12, 2022

View reviewed changes

comment

a96036a

Signed-off-by: Alyssa Wilk <[email protected]>

adisuissa approved these changes Jan 12, 2022

View reviewed changes

alyssawilk merged commit 1091423 into envoyproxy:main Jan 12, 2022

alyssawilk deleted the relnotes branch August 4, 2022 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: 1.21 #19466

release: 1.21 #19466

alyssawilk commented Jan 10, 2022 •

edited

Loading

alyssawilk Jan 10, 2022

alyssawilk commented Jan 11, 2022

adisuissa left a comment

adisuissa left a comment

adisuissa Jan 11, 2022

alyssawilk Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

adisuissa Jan 11, 2022

alyssawilk commented Jan 11, 2022

alyssawilk commented Jan 11, 2022

adisuissa left a comment

adisuissa left a comment

adisuissa Jan 12, 2022

alyssawilk commented Jan 12, 2022

adisuissa left a comment

	* dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false.
	* dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>`. This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false.

	* router: take elapsed time into account when setting the 11x-envoy-expected-rq-timeout-ms header11 for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.
	* router: take elapsed time into account when setting the ``x-envoy-expected-rq-timeout-ms`` header for retries, and never send a value that's longer than the request timeout. This behavioral change can be temporarily reverted by setting runtime guard ``envoy.reloadable_features.update_expected_rq_timeout_on_retry`` to false.

	* stream_info: response code details with empty space characters (' ', '\t', '\f', '\v', '\n', '\r') is not accepted by the ``setResponseCodeDetails()`` API.
	* stream_info: response code details with empty space characters (' ', '\\t', '\\f', '\\v', '\\n', '\\r') is not accepted by the ``setResponseCodeDetails()`` API.

	* oauth filter: setting IdToken and RefreshToken cookies if they are provided by Identity provider along with AccessToken.
	* oauth filter: setting ``IdToken`` and ``RefreshToken`` cookies if they are provided by Identity provider along with ``AccessToken``.

release: 1.21 #19466

release: 1.21 #19466

Conversation

alyssawilk commented Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

alyssawilk commented Jan 11, 2022

adisuissa left a comment

Choose a reason for hiding this comment

adisuissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alyssawilk commented Jan 11, 2022

alyssawilk commented Jan 11, 2022

adisuissa left a comment

Choose a reason for hiding this comment

adisuissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alyssawilk commented Jan 12, 2022

adisuissa left a comment

Choose a reason for hiding this comment

alyssawilk commented Jan 10, 2022 •

edited

Loading