Flip grpc client cache flag #19253
Flip grpc client cache flag #19253
Conversation
Signed-off-by: chaoqin-li1123 <[email protected]>
Signed-off-by: chaoqin-li1123 <[email protected]>
Signed-off-by: chaoqin-li1123 <[email protected]>
…grpc_client_cache_flag
|
/retest |
|
Retrying Azure Pipelines: |
|
Per our discussion, it is ok to flip a runtime even when involves many components and filters. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
alyssawilk
removed
stale
| @@ -14,6 +14,7 @@ Minor Behavior Changes | |||
| * bandwidth_limit: added :ref:`response trailers <envoy_v3_api_field_extensions.filters.http.bandwidth_limit.v3.BandwidthLimit.enable_response_trailers>` when request or response delay are enforced. | |||
| * bandwidth_limit: added :ref:`bandwidth limit stats <config_http_filters_bandwidth_limit>` *request_enforced* and *response_enforced*. | |||
| * dns: now respecting the returned DNS TTL for resolved hosts, rather than always relying on the hard-coded :ref:`dns_refresh_rate. <envoy_v3_api_field_config.cluster.v3.Cluster.dns_refresh_rate>` This behavior can be temporarily reverted by setting the runtime guard ``envoy.reloadable_features.use_dns_ttl`` to false. | |||
| * grpc: flip runtime guard ``envoy.reloadable_features.enable_grpc_async_client_cache`` to be default enabled. | |||
There was a problem hiding this comment.
Can you make sure comment what the functional change is?
Also this got lost as well due to the waiting tag, sorry. I've removed it so hopefully it will make progress again, but you'll want to main merge for current.rst
|
also needs main merge |
…grpc_client_cache_flag
Signed-off-by: chaoqin-li1123 <[email protected]>
Signed-off-by: chaoqin-li1123 <[email protected]>
|
./retest |
|
/retest |
|
Retrying Azure Pipelines: |
|
@envoyproxy/senior-maintainers assignee is @zuercher |
Risk Level: low Testing: change testing to verify new behavior Docs Changes: n/a Release Notes: added Platform Specific Features: n/a Signed-off-by: chaoqin-li1123 <[email protected]> Signed-off-by: Josh Perry <[email protected]>
Commit Message: Make grpc client cache default enable.
Additional Description:
Risk Level: low
Testing: change testing to verify new behavior
Docs Changes: document the behavior change in current.rst
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]