access_log: added new access_log command operator %UPSTREAM_REQUEST_ATTEMPT_COUNT% to retrieve the number of times given request got attempted upstream #19150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TTEMPT_COUNT% to retrieve the number of times given request got attempted upstream Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
upstream-rq-attempt-count
branch
from
849aae4 to
b1f7481
Compare
ggreenway
requested changes
Dec 1, 2021
|
@ggreenway I think it's already being set here: https://github.com/envoyproxy/envoy/blob/main/source/common/tcp_proxy/tcp_proxy.cc#L429 It should work with |
Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command operator in the access logs called
%UPSTREAM_REQUEST_ATTEMPT_COUNT%which can be used to retrieve the number of times given request got attempted upstream.This could be very helpful to triage the slow requests due to the retry. [See]
Commit Message: Added new access_log command operator %UPSTREAM_REQUEST_ATTEMPT_COUNT% to retrieve the number of times given request got attempted upstream
Additional Description: Adds a new command operator called
%UPSTREAM_REQUEST_ATTEMPT_COUNT%in the access logs which can be used to retrieve the number of times given request got attempted upstream. (Fixes #18870)Risk Level: Low
Testing: Unit Tests
Docs Changes: Added description on
%UPSTREAM_REQUEST_ATTEMPT_COUNT%in the Docs.Release Notes: Added
Platform Specific Features: N/A
Signed-off-by: Rohit Agrawal [email protected]