Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUICHE from 4f552f349 to 81314ecbd #19066

Merged

Conversation

DavidSchinazi
Copy link
Contributor

Commit Message: Update QUICHE from 4f552f349 to 81314ecbd
Additional Description: Route update, no noteworthy changes

https://github.com/google/quiche/compare/4f552f349..81314ecbd

2021-11-17 haoyuewang Internal change
2021-11-16 haoyuewang Deprecate --gfe2_restart_flag_quic_dispatcher_support_multiple_cid_per_connection_v2
2021-11-16 vasilvv Use raw hashes in WebTransportFingerprintProofVerifier.
2021-11-16 wub In TlsServerHandshaker, do not call ProofSourceHandle::SelectCertificate if QUIC connection has disconnected.
2021-11-16 quiche-dev Check for the data_deferred state before writing data for a stream.
2021-11-16 quiche-dev Consolidates references to the third-party nghttp2.h header in a single place.
2021-11-16 quiche-dev Renames Http2ErrorCode::NO_ERROR to Http2ErrorCode::HTTP2_NO_ERROR to avoid conflicts with the builtin Windows macro NO_ERROR.
2021-11-16 dschinazi Deprecate QUIC version T051
2021-11-16 quiche-dev Adds optional RST_STREAM NO_ERROR behavior after sending a fin to an incomplete request as a server.
2021-11-16 wub Deprecate --gfe2_reloadable_flag_quic_tls_restore_connection_context_in_callbacks.
2021-11-15 quiche-dev Let OgHttp2Session avoid visitor callbacks for data on unknown streams.
2021-11-15 quiche-dev Introduce NoOpHeadersHandler in OgHttp2Session.
2021-11-15 quiche-dev Extract NoOpHeadersHandler and HeaderByteListenerInterface into separate header files.
2021-11-15 quiche-dev Add testing to demonstrate nghttp2 and oghttp2 handling of data on a closed stream.
2021-11-15 quiche-dev Consolidates stream close behavior in a smaller number of places.

Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

https://github.com/google/quiche/compare/4f552f349..81314ecbd

$ git log 4f552f349..81314ecbd --date=short --no-merges --format="%ad %al %s"

2021-11-17 haoyuewang Internal change
2021-11-16 haoyuewang Deprecate --gfe2_restart_flag_quic_dispatcher_support_multiple_cid_per_connection_v2
2021-11-16 vasilvv Use raw hashes in WebTransportFingerprintProofVerifier.
2021-11-16 wub In TlsServerHandshaker, do not call ProofSourceHandle::SelectCertificate if QUIC connection has disconnected.
2021-11-16 quiche-dev Check for the data_deferred state before writing data for a stream.
2021-11-16 quiche-dev Consolidates references to the third-party nghttp2.h header in a single place.
2021-11-16 quiche-dev Renames Http2ErrorCode::NO_ERROR to Http2ErrorCode::HTTP2_NO_ERROR to avoid conflicts with the builtin Windows macro NO_ERROR.
2021-11-16 dschinazi Deprecate QUIC version T051
2021-11-16 quiche-dev Adds optional RST_STREAM NO_ERROR behavior after sending a fin to an incomplete request as a server.
2021-11-16 wub Deprecate --gfe2_reloadable_flag_quic_tls_restore_connection_context_in_callbacks.
2021-11-15 quiche-dev Let OgHttp2Session avoid visitor callbacks for data on unknown streams.
2021-11-15 quiche-dev Introduce NoOpHeadersHandler in OgHttp2Session.
2021-11-15 quiche-dev Extract NoOpHeadersHandler and HeaderByteListenerInterface into separate header files.
2021-11-15 quiche-dev Add testing to demonstrate nghttp2 and oghttp2 handling of data on a closed stream.
2021-11-15 quiche-dev Consolidates stream close behavior in a smaller number of places.

Signed-off-by: David Schinazi <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 19, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #19066 was opened by DavidSchinazi.

see: more, trace.

@DavidSchinazi
Copy link
Contributor Author

/assign @RyanTheOptimist

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Might mention in the PR description that quiche.patch is no longer needed.

@@ -1,99 +0,0 @@
--- http2/adapter/callback_visitor.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! Let's see if this sticks!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove quiche.patch from any build files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and my conclusion was that we're inevitably going to need this file again one day so I'd rather keep it as an empty file for now (as opposed to deleting the file and all references to it) to make it easier to bring it back if needed later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I really hope that we never need it again since we don't need it for Chrome. But that's probably Pollyanna-ish. SGTM!

@RyanTheOptimist
Copy link
Contributor

/assign @envoyproxy/senior-maintainers

@repokitteh-read-only
Copy link

@envoyproxy/senior-maintainers cannot be assigned to this issue.

🐱

Caused by: a #19066 (comment) was created by @RyanTheOptimist.

see: more, trace.

@RyanTheOptimist
Copy link
Contributor

/assign-from @envoyproxy/senior-maintainers

@repokitteh-read-only
Copy link

@envoyproxy/senior-maintainers assignee is @mattklein123

🐱

Caused by: a #19066 (comment) was created by @RyanTheOptimist.

see: more, trace.

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 19, 2021
@DavidSchinazi
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19066 (comment) was created by @DavidSchinazi.

see: more, trace.

@@ -1,99 +0,0 @@
--- http2/adapter/callback_visitor.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I really hope that we never need it again since we don't need it for Chrome. But that's probably Pollyanna-ish. SGTM!

@DavidSchinazi
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19066 (comment) was created by @DavidSchinazi.

see: more, trace.

@mattklein123 mattklein123 merged commit d79a3ab into envoyproxy:main Nov 19, 2021
@DavidSchinazi DavidSchinazi deleted the quiche-roll-20211119095549 branch January 27, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants