-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update QUICHE from 4f552f349 to 81314ecbd #19066
Update QUICHE from 4f552f349 to 81314ecbd #19066
Conversation
https://github.com/google/quiche/compare/4f552f349..81314ecbd $ git log 4f552f349..81314ecbd --date=short --no-merges --format="%ad %al %s" 2021-11-17 haoyuewang Internal change 2021-11-16 haoyuewang Deprecate --gfe2_restart_flag_quic_dispatcher_support_multiple_cid_per_connection_v2 2021-11-16 vasilvv Use raw hashes in WebTransportFingerprintProofVerifier. 2021-11-16 wub In TlsServerHandshaker, do not call ProofSourceHandle::SelectCertificate if QUIC connection has disconnected. 2021-11-16 quiche-dev Check for the data_deferred state before writing data for a stream. 2021-11-16 quiche-dev Consolidates references to the third-party nghttp2.h header in a single place. 2021-11-16 quiche-dev Renames Http2ErrorCode::NO_ERROR to Http2ErrorCode::HTTP2_NO_ERROR to avoid conflicts with the builtin Windows macro NO_ERROR. 2021-11-16 dschinazi Deprecate QUIC version T051 2021-11-16 quiche-dev Adds optional RST_STREAM NO_ERROR behavior after sending a fin to an incomplete request as a server. 2021-11-16 wub Deprecate --gfe2_reloadable_flag_quic_tls_restore_connection_context_in_callbacks. 2021-11-15 quiche-dev Let OgHttp2Session avoid visitor callbacks for data on unknown streams. 2021-11-15 quiche-dev Introduce NoOpHeadersHandler in OgHttp2Session. 2021-11-15 quiche-dev Extract NoOpHeadersHandler and HeaderByteListenerInterface into separate header files. 2021-11-15 quiche-dev Add testing to demonstrate nghttp2 and oghttp2 handling of data on a closed stream. 2021-11-15 quiche-dev Consolidates stream close behavior in a smaller number of places. Signed-off-by: David Schinazi <[email protected]>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
/assign @RyanTheOptimist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Might mention in the PR description that quiche.patch is no longer needed.
@@ -1,99 +0,0 @@ | |||
--- http2/adapter/callback_visitor.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY! Let's see if this sticks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove quiche.patch from any build files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it and my conclusion was that we're inevitably going to need this file again one day so I'd rather keep it as an empty file for now (as opposed to deleting the file and all references to it) to make it easier to bring it back if needed later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I really hope that we never need it again since we don't need it for Chrome. But that's probably Pollyanna-ish. SGTM!
/assign @envoyproxy/senior-maintainers |
@envoyproxy/senior-maintainers cannot be assigned to this issue. |
/assign-from @envoyproxy/senior-maintainers |
@envoyproxy/senior-maintainers assignee is @mattklein123 |
/lgtm deps |
/retest |
Retrying Azure Pipelines: |
@@ -1,99 +0,0 @@ | |||
--- http2/adapter/callback_visitor.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I really hope that we never need it again since we don't need it for Chrome. But that's probably Pollyanna-ish. SGTM!
/retest |
Retrying Azure Pipelines: |
Commit Message: Update QUICHE from 4f552f349 to 81314ecbd
Additional Description: Route update, no noteworthy changes
https://github.com/google/quiche/compare/4f552f349..81314ecbd
2021-11-17 haoyuewang Internal change
2021-11-16 haoyuewang Deprecate --gfe2_restart_flag_quic_dispatcher_support_multiple_cid_per_connection_v2
2021-11-16 vasilvv Use raw hashes in WebTransportFingerprintProofVerifier.
2021-11-16 wub In TlsServerHandshaker, do not call ProofSourceHandle::SelectCertificate if QUIC connection has disconnected.
2021-11-16 quiche-dev Check for the data_deferred state before writing data for a stream.
2021-11-16 quiche-dev Consolidates references to the third-party nghttp2.h header in a single place.
2021-11-16 quiche-dev Renames Http2ErrorCode::NO_ERROR to Http2ErrorCode::HTTP2_NO_ERROR to avoid conflicts with the builtin Windows macro NO_ERROR.
2021-11-16 dschinazi Deprecate QUIC version T051
2021-11-16 quiche-dev Adds optional RST_STREAM NO_ERROR behavior after sending a fin to an incomplete request as a server.
2021-11-16 wub Deprecate --gfe2_reloadable_flag_quic_tls_restore_connection_context_in_callbacks.
2021-11-15 quiche-dev Let OgHttp2Session avoid visitor callbacks for data on unknown streams.
2021-11-15 quiche-dev Introduce NoOpHeadersHandler in OgHttp2Session.
2021-11-15 quiche-dev Extract NoOpHeadersHandler and HeaderByteListenerInterface into separate header files.
2021-11-15 quiche-dev Add testing to demonstrate nghttp2 and oghttp2 handling of data on a closed stream.
2021-11-15 quiche-dev Consolidates stream close behavior in a smaller number of places.
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A